LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Harvey Harrison <harvey.harrison@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	stable@kernel.org
Subject: Re: [patch] fuse: fix permission checking
Date: Fri, 15 Feb 2008 12:35:38 -0800	[thread overview]
Message-ID: <1203107738.15275.39.camel@brick> (raw)
In-Reply-To: <E1JPxjP-0004sQ-5O@pomaz-ex.szeredi.hu>

On Fri, 2008-02-15 at 11:23 +0100, Miklos Szeredi wrote:
> This is for 2.6.25 and 2.6.24.y, but NOT for 2.6.23.y.
> 
> Thanks,
> Miklos
> ----
> 
> From: Miklos Szeredi <mszeredi@suse.cz>
> 
> I added a nasty local variable shadowing bug to fuse in 2.6.24, with
> the result, that the 'default_permissions' mount option is basically
> ignored.
> 
> How did this happen?
> 
>  - old err declaration in inner scope
>  - new err getting declared in outer scope
>  - 'return err' from inner scope getting removed
>  - old declaration not being noticed
> 
> -Wshadow would have saved us, but it doesn't seem practical for
> the kernel :(
> 
> More testing would have also saved us :((

sparse would have saved you too.

Harvey


  reply	other threads:[~2008-02-15 20:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 10:23 Miklos Szeredi
2008-02-15 20:35 ` Harvey Harrison [this message]
2008-02-22 23:19 ` [stable] " Greg KH
2008-02-23  9:38   ` Miklos Szeredi
2008-02-23 19:08     ` Greg KH
2008-02-23 19:22       ` Andrew Morton
2008-02-23 19:40         ` Miklos Szeredi
2008-02-25 10:45   ` Miklos Szeredi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203107738.15275.39.camel@brick \
    --to=harvey.harrison@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=stable@kernel.org \
    --subject='Re: [patch] fuse: fix permission checking' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).