LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li@intel.com>
To: "Дамјан Георгиевски" <penguinista@mail.net.mk>
Cc: Greg KH <greg@kroah.com>, lkml <linux-kernel@vger.kernel.org>,
	linux-pci <linux-pci@atrey.karlin.mff.cuni.cz>,
	"Kok, Auke" <auke-jan.h.kok@intel.com>
Subject: Re: PCIE ASPM support hangs my laptop pretty often
Date: Tue, 19 Feb 2008 13:55:58 +0800	[thread overview]
Message-ID: <1203400558.12681.18.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <200802051840.05237.penguinista@mail.net.mk>


On Wed, 2008-02-06 at 01:40 +0800, Дамјан Георгиевски wrote:
> I've patched my kernel with the PCIe ASPM and after setting
> echo powersave > /sys/module/pcie_aspm/parameters/policy
> 
> I started to experience random hangs of my laptop.
> Hardware info:
> Thinkpad x60s 1704-5UG
> also tested on a firends X60s 1702-F6U
> 
> Kernel is 2.6.24 + these patches:
>  tuxonice 3.0-rc5
>  thinkpad_acpi v0.19-20080107
>  tp_smapi 0.36
Hi,
Sorry for the long delay, I'm just back from vocation. Some devices or
chipsets don't work well with ASPM. This is one of the reason why the
default policy of the patch is per BIOS setting. Ideally drivers should
disable ASPM for specific devices, the patch provides an API
(pci_disable_link_state) for this too. As Auke suggested, you can use
the per-device interface to control separate links to see which device
is broken. If you found one, please report to driver maintainer and me,
we can disable ASPM in the driver.

Thanks,
Shaohua


      parent reply	other threads:[~2008-02-19  6:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 17:40 Дамјан Георгиевски
2008-02-05 18:46 ` Arjan van de Ven
2008-02-05 18:51   ` Greg KH
2008-02-05 20:58     ` Kok, Auke
2008-02-06  0:05       ` Дамјан Георгиевски
2008-02-06  0:22         ` Kok, Auke
2008-02-06 13:00           ` Pavel Machek
2008-02-06 17:25             ` Rafael J. Wysocki
2008-02-06 21:46               ` Kok, Auke
2008-02-06 21:58                 ` Greg KH
2008-02-19  5:55 ` Shaohua Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203400558.12681.18.camel@sli10-desk.sh.intel.com \
    --to=shaohua.li@intel.com \
    --cc=auke-jan.h.kok@intel.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=penguinista@mail.net.mk \
    --subject='Re: PCIE ASPM support hangs my laptop pretty often' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).