LKML Archive on
help / color / mirror / Atom feed
From: Andy Whitcroft <>
To: Andrew Morton <>
Cc: Adam Litke <>,
	Nishanth Aravamudan <>,
	William Irwin <>,,
Subject: [PATCH] hugetlb: ensure we do not reference a surplus page after handing it to buddy
Date: Tue, 19 Feb 2008 18:28:08 -0000	[thread overview]
Message-ID: <1203445688.0@pinky> (raw)

When we free a page via free_huge_page and we detect that we are in
surplus the page will be returned to the buddy.  After this we no longer
own the page.  However at the end free_huge_page we clear out our mapping
pointer from page private.  Even where the page is not a surplus we
free the page to the hugepage pool, drop the pool locks and then clear
page private.  In either case the page may have been reallocated.  BAD.

Make sure we clear out page private before we free the page.

Signed-off-by: Andy Whitcroft <>
 mm/hugetlb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index cb1b3a7..89e6286 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -120,6 +120,7 @@ static void free_huge_page(struct page *page)
 	struct address_space *mapping;
 	mapping = (struct address_space *) page_private(page);
+	set_page_private(page, 0);
@@ -134,7 +135,6 @@ static void free_huge_page(struct page *page)
 	if (mapping)
 		hugetlb_put_quota(mapping, 1);
-	set_page_private(page, 0);

             reply	other threads:[~2008-02-19 18:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-19 18:28 Andy Whitcroft [this message]
2008-02-19 18:41 ` Adam Litke
2008-02-19 23:30   ` Andrew Morton
2008-02-20 14:59     ` Adam Litke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203445688.0@pinky \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] hugetlb: ensure we do not reference a surplus page after handing it to buddy' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).