LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Shaohua Li <shaohua.li@intel.com>
To: Greg KH <gregkh@suse.de>
Cc: Greg KH <greg@kroah.com>, Ingo Molnar <mingo@elte.hu>,
	"Kok, Auke-jan H" <auke-jan.h.kok@intel.com>,
	linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
	matthew@wil.cx, "Pallipadi,
	Venkatesh" <venkatesh.pallipadi@intel.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree
Date: Wed, 20 Feb 2008 12:48:21 +0800	[thread overview]
Message-ID: <1203482901.23071.5.camel@sli10-desk.sh.intel.com> (raw)
In-Reply-To: <20080220041400.GA18771@suse.de>


On Tue, 2008-02-19 at 20:14 -0800, Greg KH wrote:
> On Wed, Feb 20, 2008 at 09:36:07AM +0800, Shaohua Li wrote:
> > --- linux.orig/include/linux/pci-acpi.h	2008-02-19 11:03:51.000000000 +0800
> > +++ linux/include/linux/pci-acpi.h	2008-02-20 09:19:15.000000000 +0800
> > @@ -47,6 +47,7 @@
> >  				OSC_PCI_EXPRESS_CAP_STRUCTURE_CONTROL)
> >  
> >  #ifdef CONFIG_ACPI
> > +#include <acpi/acpi_bus.h>
> >  extern acpi_status pci_osc_control_set(acpi_handle handle, u32 flags);
> >  extern acpi_status __pci_osc_support_set(u32 flags, const char *hid);
> >  static inline acpi_status pci_osc_support_set(u32 flags)
> > @@ -59,13 +60,11 @@ static inline acpi_status pcie_osc_suppo
> >  }
> >  #else
> >  #if !defined(AE_ERROR)
> > -typedef u32 		acpi_status;
> > -#define AE_ERROR      	(acpi_status) (0x0001)
> > -#endif    
> > -static inline acpi_status pci_osc_control_set(acpi_handle handle, u32 flags)
> > -{return AE_ERROR;}
> > -static inline acpi_status pci_osc_support_set(u32 flags) {return AE_ERROR;} 
> > -static inline acpi_status pcie_osc_support_set(u32 flags) {return AE_ERROR;}
> > +#define AE_ERROR      	(0x0001)
> > +#endif
> > +#define pci_osc_control_set(handle, flags) (AE_ERROR)
> > +#define pci_osc_support_set(flags) (AE_ERROR)
> > +#define pcie_osc_support_set(flags) (AE_ERROR)
> 
> No, please use inline functions, don't change these functions that
> should be just fine.  Why are you needing to change them?
some types aren't defined in non-ACPI, like acpi_handle, acpi_status.

Thanks,
Shaohua


  reply	other threads:[~2008-02-20  4:58 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-18  1:56 [PATCH]PCIE ASPM support - takes 3 Shaohua Li
2008-01-22 22:58 ` Greg KH
2008-01-23  2:20   ` Shaohua Li
2008-01-23 18:26     ` Greg KH
2008-01-24  2:21       ` Shaohua Li
2008-01-25 22:41         ` patch pci-pcie-aspm-support.patch added to gregkh-2.6 tree gregkh
2008-02-02 10:55           ` [bootup crash, -git] " Ingo Molnar
2008-02-02 18:51             ` Greg KH
2008-02-02 19:37               ` Ingo Molnar
2008-02-19  5:45               ` [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded " Shaohua Li
2008-02-19 23:45                 ` Greg KH
2008-02-20  1:36                   ` Shaohua Li
2008-02-20  4:14                     ` Greg KH
2008-02-20  4:48                       ` Shaohua Li [this message]
2008-02-20  5:04                         ` Greg KH
2008-02-20  5:24                           ` Shaohua Li
2008-02-20  5:42                             ` Greg KH
2008-02-20  6:21                               ` Shaohua Li
2008-01-24 17:22 ` [PATCH]PCIE ASPM support - takes 3 Pavel Machek
2008-01-25  8:01   ` Li, Shaohua
2008-01-28 23:14   ` Kok, Auke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1203482901.23071.5.camel@sli10-desk.sh.intel.com \
    --to=shaohua.li@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=auke-jan.h.kok@intel.com \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=venkatesh.pallipadi@intel.com \
    --subject='Re: [bootup crash, -git] Re: patch pci-pcie-aspm-support.patchadded to gregkh-2.6 tree' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).