LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi> To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: "David Miller" <davem@davemloft.net>, "Arnaldo Carvalho de Melo" <acme@redhat.com>, "Ilpo J�rvinen" <ilpo.jarvinen@helsinki.fi> Subject: [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot Date: Wed, 20 Feb 2008 15:47:13 +0200 [thread overview] Message-ID: <1203515238-22848-4-git-send-email-ilpo.jarvinen@helsinki.fi> (raw) In-Reply-To: <1203515238-22848-3-git-send-email-ilpo.jarvinen@helsinki.fi> -23668 392 funcs, 104 +, 23772 -, diff: -23668 --- dev_alloc_skb Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@helsinki.fi> --- include/linux/skbuff.h | 17 +---------------- net/core/skbuff.c | 18 ++++++++++++++++++ 2 files changed, 19 insertions(+), 16 deletions(-) diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h index a9f8f15..df3cce2 100644 --- a/include/linux/skbuff.h +++ b/include/linux/skbuff.h @@ -1269,22 +1269,7 @@ static inline struct sk_buff *__dev_alloc_skb(unsigned int length, return skb; } -/** - * dev_alloc_skb - allocate an skbuff for receiving - * @length: length to allocate - * - * Allocate a new &sk_buff and assign it a usage count of one. The - * buffer has unspecified headroom built in. Users should allocate - * the headroom they think they need without accounting for the - * built in space. The built in space is used for optimisations. - * - * %NULL is returned if there is no free memory. Although this function - * allocates memory it can be called from an interrupt. - */ -static inline struct sk_buff *dev_alloc_skb(unsigned int length) -{ - return __dev_alloc_skb(length, GFP_ATOMIC); -} +extern struct sk_buff *dev_alloc_skb(unsigned int length); extern struct sk_buff *__netdev_alloc_skb(struct net_device *dev, unsigned int length, gfp_t gfp_mask); diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 14f462b..081bffb 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -263,6 +263,24 @@ struct sk_buff *__netdev_alloc_skb(struct net_device *dev, return skb; } +/** + * dev_alloc_skb - allocate an skbuff for receiving + * @length: length to allocate + * + * Allocate a new &sk_buff and assign it a usage count of one. The + * buffer has unspecified headroom built in. Users should allocate + * the headroom they think they need without accounting for the + * built in space. The built in space is used for optimisations. + * + * %NULL is returned if there is no free memory. Although this function + * allocates memory it can be called from an interrupt. + */ +struct sk_buff *dev_alloc_skb(unsigned int length) +{ + return __dev_alloc_skb(length, GFP_ATOMIC); +} +EXPORT_SYMBOL(dev_alloc_skb); + static void skb_drop_list(struct sk_buff **listp) { struct sk_buff *list = *listp; -- 1.5.2.2
next prev parent reply other threads:[~2008-02-20 13:48 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-02-20 13:47 [RFC PATCH 0/8]: uninline & uninline Ilpo Järvinen 2008-02-20 13:47 ` [RFC PATCH 1/8] [NET]: uninline skb_put, de-bloats a lot Ilpo Järvinen 2008-02-20 13:47 ` [RFC PATCH 2/8] [NET]: uninline skb_pull, " Ilpo Järvinen 2008-02-20 13:47 ` Ilpo Järvinen [this message] 2008-02-20 13:47 ` [RFC PATCH 4/8] [NET]: uninline skb_push, " Ilpo Järvinen 2008-02-20 13:47 ` [RFC PATCH 5/8] [NET]: uninline dst_release Ilpo Järvinen 2008-02-20 13:47 ` [RFC PATCH 6/8] [NET]: uninline skb_trim, de-bloats Ilpo Järvinen 2008-02-20 13:47 ` [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf Ilpo Järvinen 2008-02-20 13:47 ` [RFC PATCH 8/8] Jhash in too big for inlining, move under lib/ Ilpo Järvinen 2008-02-23 8:02 ` Andrew Morton 2008-02-23 10:05 ` Ilpo Järvinen 2008-02-23 18:21 ` Andrew Morton 2008-02-23 13:06 ` Andi Kleen 2008-02-20 22:16 ` [RFC PATCH 7/8] [SCTP]: uninline sctp_add_cmd_sf Vlad Yasevich 2008-02-20 22:34 ` Ilpo Järvinen 2008-02-21 15:27 ` Vlad Yasevich 2008-02-20 16:19 ` [RFC PATCH 3/8] [NET]: uninline dev_alloc_skb, de-bloats a lot Jan Engelhardt 2008-02-20 16:27 ` Patrick McHardy 2008-02-20 16:30 ` Jan Engelhardt 2008-02-20 22:18 ` Ilpo Järvinen 2008-03-12 15:27 ` Ilpo Järvinen 2008-02-20 13:54 ` [RFC PATCH 1/8] [NET]: uninline skb_put, " Patrick McHardy 2008-02-20 13:57 ` Eric Dumazet 2008-02-23 8:02 ` [RFC PATCH 0/8]: uninline & uninline Andrew Morton 2008-02-23 10:11 ` Ilpo Järvinen 2008-02-23 13:15 ` Andi Kleen 2008-02-23 18:06 ` Ilpo Järvinen 2008-02-23 18:55 ` Andrew Morton 2008-02-23 19:58 ` Hua Zhong 2008-02-23 21:02 ` Andi Kleen 2008-02-27 19:08 ` profile-likely patch (was " Valdis.Kletnieks
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1203515238-22848-4-git-send-email-ilpo.jarvinen@helsinki.fi \ --to=ilpo.jarvinen@helsinki.fi \ --cc=acme@redhat.com \ --cc=davem@davemloft.net \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).