LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Adam Litke <agl@us.ibm.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Whitcroft <apw@shadowen.org>,
Nishanth Aravamudan <nacc@us.ibm.com>,
William Irwin <wli@holomorphy.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hugetlb: ensure we do not reference a surplus page after handing it to buddy
Date: Wed, 20 Feb 2008 08:59:34 -0600 [thread overview]
Message-ID: <1203519574.11987.67.camel@localhost.localdomain> (raw)
In-Reply-To: <20080219153037.ec336fd2.akpm@linux-foundation.org>
On Tue, 2008-02-19 at 15:30 -0800, Andrew Morton wrote:
> On Tue, 19 Feb 2008 12:41:51 -0600 Adam Litke <agl@us.ibm.com> wrote:
>
> > Indeed. I'll take credit for this thinko...
> >
> > On Tue, 2008-02-19 at 18:28 +0000, Andy Whitcroft wrote:
> > > When we free a page via free_huge_page and we detect that we are in
> > > surplus the page will be returned to the buddy. After this we no longer
> > > own the page. However at the end free_huge_page we clear out our mapping
> > > pointer from page private. Even where the page is not a surplus we
> > > free the page to the hugepage pool, drop the pool locks and then clear
> > > page private. In either case the page may have been reallocated. BAD.
> > >
> > > Make sure we clear out page private before we free the page.
> > >
> > > Signed-off-by: Andy Whitcroft <apw@shadowen.org>
> >
> > Acked-by: Adam Litke <agl@us.ibm.com>
>
> Was I right to assume that this is also needed in 2.6.24.x?
Yep. Thanks Andrew.
--
Adam Litke - (agl at us.ibm.com)
IBM Linux Technology Center
prev parent reply other threads:[~2008-02-20 14:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-19 18:28 Andy Whitcroft
2008-02-19 18:41 ` Adam Litke
2008-02-19 23:30 ` Andrew Morton
2008-02-20 14:59 ` Adam Litke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203519574.11987.67.camel@localhost.localdomain \
--to=agl@us.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nacc@us.ibm.com \
--cc=wli@holomorphy.com \
--subject='Re: [PATCH] hugetlb: ensure we do not reference a surplus page after handing it to buddy' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).