LKML Archive on
help / color / mirror / Atom feed
* [PATCH] hugetlb: ensure we do not reference a surplus page after handing it to buddy
@ 2008-02-19 18:28 Andy Whitcroft
  2008-02-19 18:41 ` Adam Litke
  0 siblings, 1 reply; 4+ messages in thread
From: Andy Whitcroft @ 2008-02-19 18:28 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Adam Litke, Nishanth Aravamudan, William Irwin, linux-mm, linux-kernel

When we free a page via free_huge_page and we detect that we are in
surplus the page will be returned to the buddy.  After this we no longer
own the page.  However at the end free_huge_page we clear out our mapping
pointer from page private.  Even where the page is not a surplus we
free the page to the hugepage pool, drop the pool locks and then clear
page private.  In either case the page may have been reallocated.  BAD.

Make sure we clear out page private before we free the page.

Signed-off-by: Andy Whitcroft <>
 mm/hugetlb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/hugetlb.c b/mm/hugetlb.c
index cb1b3a7..89e6286 100644
--- a/mm/hugetlb.c
+++ b/mm/hugetlb.c
@@ -120,6 +120,7 @@ static void free_huge_page(struct page *page)
 	struct address_space *mapping;
 	mapping = (struct address_space *) page_private(page);
+	set_page_private(page, 0);
@@ -134,7 +135,6 @@ static void free_huge_page(struct page *page)
 	if (mapping)
 		hugetlb_put_quota(mapping, 1);
-	set_page_private(page, 0);

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2008-02-20 14:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-19 18:28 [PATCH] hugetlb: ensure we do not reference a surplus page after handing it to buddy Andy Whitcroft
2008-02-19 18:41 ` Adam Litke
2008-02-19 23:30   ` Andrew Morton
2008-02-20 14:59     ` Adam Litke

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).