LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2/2] nfsd: fix sparse warning in vfs.c
@ 2008-02-20 20:49 Harvey Harrison
2008-02-20 23:38 ` J. Bruce Fields
0 siblings, 1 reply; 2+ messages in thread
From: Harvey Harrison @ 2008-02-20 20:49 UTC (permalink / raw)
To: J. Bruce Fields, Neil Brown; +Cc: Andrew Morton, LKML
fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
fs/nfsd/vfs.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 0265310..17ac51b 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -988,7 +988,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
* flushing the data to disk is handled separately below.
*/
- if (file->f_op->fsync == 0) {/* COMMIT3 cannot work */
+ if (!file->f_op->fsync) {/* COMMIT3 cannot work */
stable = 2;
*stablep = 2; /* FILE_SYNC */
}
--
1.5.4.2.200.g99e75
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 2/2] nfsd: fix sparse warning in vfs.c
2008-02-20 20:49 [PATCH 2/2] nfsd: fix sparse warning in vfs.c Harvey Harrison
@ 2008-02-20 23:38 ` J. Bruce Fields
0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2008-02-20 23:38 UTC (permalink / raw)
To: Harvey Harrison; +Cc: Neil Brown, Andrew Morton, LKML
On Wed, Feb 20, 2008 at 12:49:02PM -0800, Harvey Harrison wrote:
> fs/nfsd/vfs.c:991:27: warning: Using plain integer as NULL pointer
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> fs/nfsd/vfs.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Also applied, thanks.--b.
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 0265310..17ac51b 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -988,7 +988,7 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct file *file,
> * flushing the data to disk is handled separately below.
> */
>
> - if (file->f_op->fsync == 0) {/* COMMIT3 cannot work */
> + if (!file->f_op->fsync) {/* COMMIT3 cannot work */
> stable = 2;
> *stablep = 2; /* FILE_SYNC */
> }
> --
> 1.5.4.2.200.g99e75
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-20 23:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-20 20:49 [PATCH 2/2] nfsd: fix sparse warning in vfs.c Harvey Harrison
2008-02-20 23:38 ` J. Bruce Fields
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).