LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-kernel@vger.kernel.org,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
Haavard Skinnemoen <hskinnemoen@atmel.com>
Subject: [PATCH] macb: Fix speed setting
Date: Thu, 21 Feb 2008 17:41:05 +0100 [thread overview]
Message-ID: <1203612065-18192-1-git-send-email-hskinnemoen@atmel.com> (raw)
In-Reply-To: <20080221.225054.61509660.anemo@mba.ocn.ne.jp>
From: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Fix NCFGR.SPD setting on 10Mbps. This bug was introduced by
conversion to generic PHY layer in kernel 2.6.23.
Signed-off-by: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
---
drivers/net/macb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/macb.c b/drivers/net/macb.c
index 81bf005..1d210ed 100644
--- a/drivers/net/macb.c
+++ b/drivers/net/macb.c
@@ -148,7 +148,7 @@ static void macb_handle_link_change(struct net_device *dev)
if (phydev->duplex)
reg |= MACB_BIT(FD);
- if (phydev->speed)
+ if (phydev->speed == SPEED_100)
reg |= MACB_BIT(SPD);
macb_writel(bp, NCFGR, reg);
--
1.5.4.1
next prev parent reply other threads:[~2008-02-21 16:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 13:50 Atsushi Nemoto
2008-02-21 14:12 ` Haavard Skinnemoen
2008-02-21 15:04 ` Atsushi Nemoto
2008-02-21 15:07 ` Atsushi Nemoto
2008-02-21 16:39 ` Haavard Skinnemoen
2008-02-21 16:41 ` Haavard Skinnemoen [this message]
2008-02-22 9:05 ` Haavard Skinnemoen
2008-02-23 8:03 ` Andrew Morton
2008-02-24 0:50 ` Haavard Skinnemoen
2008-02-24 5:11 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1203612065-18192-1-git-send-email-hskinnemoen@atmel.com \
--to=hskinnemoen@atmel.com \
--cc=anemo@mba.ocn.ne.jp \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--subject='Re: [PATCH] macb: Fix speed setting' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).