LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [2.6 patch] make xen-blkfront.c:blkif_getgeo() static
@ 2008-02-22 19:58 Adrian Bunk
  2008-02-22 20:44 ` Ian Campbell
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-02-22 19:58 UTC (permalink / raw)
  To: Ian Campbell, Jeremy Fitzhardinge, chrisw; +Cc: xen-devel, linux-kernel

This patch makes the needlessly global blkif_getgeo() static.

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---
6f34bfdbb8c24e06d982ccaccd24c25dba5b1956 diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 9c6f3f9..ae7ee16 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -136,7 +136,7 @@ static void blkif_restart_queue_callback(void *arg)
 	schedule_work(&info->work);
 }
 
-int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
+static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
 {
 	/* We don't have real geometry info, but let's at least return
 	   values consistent with the size of the device */


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [2.6 patch] make xen-blkfront.c:blkif_getgeo() static
  2008-02-22 19:58 [2.6 patch] make xen-blkfront.c:blkif_getgeo() static Adrian Bunk
@ 2008-02-22 20:44 ` Ian Campbell
  0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2008-02-22 20:44 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Jeremy Fitzhardinge, chrisw, xen-devel, linux-kernel


On Fri, 2008-02-22 at 21:58 +0200, Adrian Bunk wrote:
> This patch makes the needlessly global blkif_getgeo() static.
> 
> Signed-off-by: Adrian Bunk <bunk@kernel.org>

Acked-by: Ian Campbell <ijc@hellion.org.uk>

> 
> ---
> 6f34bfdbb8c24e06d982ccaccd24c25dba5b1956 diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 9c6f3f9..ae7ee16 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -136,7 +136,7 @@ static void blkif_restart_queue_callback(void *arg)
>  	schedule_work(&info->work);
>  }
>  
> -int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
> +static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
>  {
>  	/* We don't have real geometry info, but let's at least return
>  	   values consistent with the size of the device */
> 
> 
-- 
Ian Campbell

WHERE CAN THE MATTER BE
	Oh, dear, where can the matter be
	When it's converted to energy?
	There is a slight loss of parity.
	Johnny's so long at the fair.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-02-22 20:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-22 19:58 [2.6 patch] make xen-blkfront.c:blkif_getgeo() static Adrian Bunk
2008-02-22 20:44 ` Ian Campbell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).