LKML Archive on
help / color / mirror / Atom feed
From: "Alexander van Heukelum" <>
To: "Sam Ravnborg" <>
Cc: "Geert Uytterhoeven" <>,
	"Andrew Morton" <>,
	"lkml" <>,,
	"Alexander van Heukelum" <>
Subject: Re: Lump xxxinit together with init if possible (was Re: Solve section mismatch for free_area_init_core.)
Date: Sat, 23 Feb 2008 21:20:39 +0100	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Sat, 23 Feb 2008 18:53:06 +0100, "Sam Ravnborg" <>
> Hi Alexander.
> > I more than less expected people to scream "ugly, ugly!".
> That was my first thought and the reason why it stayed in my inbox
> for so long.
> But I could not find a better way to do it. We could do it in
> different ways but not better.
> > Maybe you could consider the following patch, instead?
> > In non-HOTPLUG configurations, devinit and init sections in vmlinux
> > are lumped together during the final link. There is no good reason
> > to warn about section mismatches between them in this case, because
> > all code is discarded at the same time. This patch moves the lumping-
> > together to the compile stage, which makes the unnecessary warnings
> > go away. Same for MEMORY_HOTPLUG/meminit and HOTPLUG_CPU/cpuinit.
> From the commit where the seperate section were introduced:
>     Introducing separate sections for __dev* (HOTPLUG),
>     __cpu* (HOTPLUG_CPU) and __mem* (MEMORY_HOTPLUG)
>     allows us to do a much more reliable Section mismatch
>     check in modpost. We are no longer dependent on the actual
>     configuration of for example HOTPLUG.
> I think that explains it.

I should have looked at that commit first. Indeed, it does explain
why it is better to keep the sections separate. Thanks.
  Alexander van Heukelum

-- - Choose from over 50 domains or use your own

      reply	other threads:[~2008-02-23 20:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03 17:21 Solve section mismatch for free_area_init_core Alexander van Heukelum
2008-02-18 21:01 ` Sam Ravnborg
2008-02-19  8:30   ` Geert Uytterhoeven
2008-02-23 16:30     ` Lump xxxinit together with init if possible (was Re: Solve section mismatch for free_area_init_core.) Alexander van Heukelum
2008-02-23 17:53       ` Sam Ravnborg
2008-02-23 20:20         ` Alexander van Heukelum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).