[PATCH] x86: fix build on non-C locales.

[PATCH] x86: fix build on non-C locales.

[Priit Laes]

[-- Attachment #1: Type: text/plain, Size: 1 bytes --]



[-- Attachment #2: Type: text/x-patch, Size: 868 bytes --]

x86: fix build on some non-C locales[1].

For some locales regex range [a-zA-Z] does not work as it is supposed to 
so we have to specify LANG=C to make it work as intended.

[1] http://en.wikipedia.org/wiki/Estonian_alphabet

Signed-off-by: Priit Laes <plaes@plaes.org>

diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
index f385a4b..c58e7b9 100644
--- a/arch/x86/vdso/Makefile
+++ b/arch/x86/vdso/Makefile
@@ -50,7 +50,8 @@ obj-$(VDSO64-y)			+= vdso-syms.lds
 sed-vdsosym := -e 's/^00*/0/' \
 	-e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p'
 quiet_cmd_vdsosym = VDSOSYM $@
-      cmd_vdsosym = $(NM) $< | sed -n $(sed-vdsosym) | LC_ALL=C sort > $@
+      cmd_vdsosym = $(NM) $< | LC_ALL=C sed -n $(sed-vdsosym) \
+	  		| LC_ALL=C sort > $@
 
 $(obj)/%-syms.lds: $(obj)/%.so.dbg FORCE
 	$(call if_changed,vdsosym)

Re: [PATCH] x86: fix build on non-C locales.

[Ingo Molnar]

* Priit Laes <plaes@plaes.org> wrote:

> x86: fix build on some non-C locales[1].
> 
> For some locales regex range [a-zA-Z] does not work as it is supposed 
> to so we have to specify LANG=C to make it work as intended.

thanks, applied.

	Ingo

Re: [PATCH] x86: fix build on non-C locales.

[Sam Ravnborg]

Hi Prit.

Could we just use [[:alnum:]] and drop the setting of LC_ALL?

	Sam

Re: [PATCH] x86: fix build on non-C locales.

[Priit Laes]

Ühel kenal päeval, P, 2008-02-24 kell 10:03, kirjutas Sam Ravnborg:
> Hi Prit.
> 
> Could we just use [[:alnum:]] and drop the setting of LC_ALL?
Yes, it works. Reverted the previous patch and did this:

diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
index f385a4b..b8bd0c4 100644
--- a/arch/x86/vdso/Makefile
+++ b/arch/x86/vdso/Makefile
@@ -48,7 +48,7 @@ obj-$(VDSO64-y)                       += vdso-syms.lds
 # Match symbols in the DSO that look like VDSO*; produce a file of
constants.
 #
 sed-vdsosym := -e 's/^00*/0/' \
-       -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p'
+       -e 's/^\([[:xdigit:]]*\) . \(VDSO[[:alnum:]_]*\)$$/\2 = 0x\1;/p'
 quiet_cmd_vdsosym = VDSOSYM $@
       cmd_vdsosym = $(NM) $< | sed -n $(sed-vdsosym) | LC_ALL=C sort >
$@

Re: [PATCH] x86: fix build on non-C locales.

[Ingo Molnar]

* Priit Laes <plaes@plaes.org> wrote:

>  sed-vdsosym := -e 's/^00*/0/' \
> -       -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p'
> +       -e 's/^\([[:xdigit:]]*\) . \(VDSO[[:alnum:]_]*\)$$/\2 = 0x\1;/p'

thanks, i picked up this one instead of the first version.

	Ingo