LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH 2/6] xen: make blkif_getgeo static
       [not found] <5ce117613299590dd08d11d24d3a33d9077fe2b0.1203898924.git.harvey.harrison@gmail.com>
@ 2008-02-25  0:25 ` Harvey Harrison
  2008-02-25  0:25 ` [PATCH 3/6] agp: fix shadowed variable warning in amd-k7-agp.c Harvey Harrison
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 5+ messages in thread
From: Harvey Harrison @ 2008-02-25  0:25 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: LKML, Andrew Morton

Introduced between 2.6.25-rc2 and -rc3
drivers/block/xen-blkfront.c:139:5: warning: symbol 'blkif_getgeo' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 drivers/block/xen-blkfront.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
index 9c6f3f9..ae7ee16 100644
--- a/drivers/block/xen-blkfront.c
+++ b/drivers/block/xen-blkfront.c
@@ -136,7 +136,7 @@ static void blkif_restart_queue_callback(void *arg)
 	schedule_work(&info->work);
 }
 
-int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
+static int blkif_getgeo(struct block_device *bd, struct hd_geometry *hg)
 {
 	/* We don't have real geometry info, but let's at least return
 	   values consistent with the size of the device */
-- 
1.5.4.2.200.g99e75



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 4/6] smack: make functions static
       [not found] <5ce117613299590dd08d11d24d3a33d9077fe2b0.1203898924.git.harvey.harrison@gmail.com>
  2008-02-25  0:25 ` [PATCH 2/6] xen: make blkif_getgeo static Harvey Harrison
  2008-02-25  0:25 ` [PATCH 3/6] agp: fix shadowed variable warning in amd-k7-agp.c Harvey Harrison
@ 2008-02-25  0:25 ` Harvey Harrison
  2008-02-25  0:25 ` [PATCH 5/6] block: remove extern on function definition Harvey Harrison
  2008-02-25  0:25 ` [PATCH 6/6] block: fix shadowed variable warning in blk-map.c Harvey Harrison
  4 siblings, 0 replies; 5+ messages in thread
From: Harvey Harrison @ 2008-02-25  0:25 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Andrew Morton, LKML

Introduced between 2.6.25-rc2 and -rc3
security/smack/smackfs.c:374:6: warning: symbol 'smk_unlbl_ambient' was not declared. Should it be static?

While here, take care of this one too.
security/smack/smackfs.c:341:6: warning: symbol 'smk_cipso_doi' was not declared. Should it be static?

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 security/smack/smackfs.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/security/smack/smackfs.c b/security/smack/smackfs.c
index 358c92c..cb26951 100644
--- a/security/smack/smackfs.c
+++ b/security/smack/smackfs.c
@@ -338,7 +338,7 @@ static const struct file_operations smk_load_ops = {
 /**
  * smk_cipso_doi - initialize the CIPSO domain
  */
-void smk_cipso_doi(void)
+static void smk_cipso_doi(void)
 {
 	int rc;
 	struct cipso_v4_doi *doip;
@@ -371,7 +371,7 @@ void smk_cipso_doi(void)
 /**
  * smk_unlbl_ambient - initialize the unlabeled domain
  */
-void smk_unlbl_ambient(char *oldambient)
+static void smk_unlbl_ambient(char *oldambient)
 {
 	int rc;
 	struct netlbl_audit audit_info;
-- 
1.5.4.2.200.g99e75



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 3/6] agp: fix shadowed variable warning in amd-k7-agp.c
       [not found] <5ce117613299590dd08d11d24d3a33d9077fe2b0.1203898924.git.harvey.harrison@gmail.com>
  2008-02-25  0:25 ` [PATCH 2/6] xen: make blkif_getgeo static Harvey Harrison
@ 2008-02-25  0:25 ` Harvey Harrison
  2008-02-25  0:25 ` [PATCH 4/6] smack: make functions static Harvey Harrison
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 5+ messages in thread
From: Harvey Harrison @ 2008-02-25  0:25 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: LKML, Andrew Morton

Introduced between 2.6.25-rc2 and -rc3
drivers/char/agp/amd-k7-agp.c:439:6: warning: symbol 'cap_ptr' shadows an earlier one
drivers/char/agp/amd-k7-agp.c:414:5: originally declared here

cap_ptr is never used again in this function, don't bother redeclaring.

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 drivers/char/agp/amd-k7-agp.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/char/agp/amd-k7-agp.c b/drivers/char/agp/amd-k7-agp.c
index d286699..96bdb92 100644
--- a/drivers/char/agp/amd-k7-agp.c
+++ b/drivers/char/agp/amd-k7-agp.c
@@ -436,8 +436,9 @@ static int __devinit agp_amdk7_probe(struct pci_dev *pdev,
 	   system controller may experience noise due to strong drive strengths
 	 */
 	if (agp_bridge->dev->device == PCI_DEVICE_ID_AMD_FE_GATE_7006) {
-		u8 cap_ptr=0;
 		struct pci_dev *gfxcard=NULL;
+
+		cap_ptr = 0;
 		while (!cap_ptr) {
 			gfxcard = pci_get_class(PCI_CLASS_DISPLAY_VGA<<8, gfxcard);
 			if (!gfxcard) {
-- 
1.5.4.2.200.g99e75



^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 6/6] block: fix shadowed variable warning in blk-map.c
       [not found] <5ce117613299590dd08d11d24d3a33d9077fe2b0.1203898924.git.harvey.harrison@gmail.com>
                   ` (3 preceding siblings ...)
  2008-02-25  0:25 ` [PATCH 5/6] block: remove extern on function definition Harvey Harrison
@ 2008-02-25  0:25 ` Harvey Harrison
  4 siblings, 0 replies; 5+ messages in thread
From: Harvey Harrison @ 2008-02-25  0:25 UTC (permalink / raw)
  To: Linus Torvalds, Jens Axboe; +Cc: Andrew Morton, LKML

Introduced between 2.6.25-rc2 and -rc3
block/blk-map.c:154:14: warning: symbol 'bio' shadows an earlier one
block/blk-map.c:110:13: originally declared here

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 block/blk-map.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/block/blk-map.c b/block/blk-map.c
index 09f7fd0..f443c21 100644
--- a/block/blk-map.c
+++ b/block/blk-map.c
@@ -151,10 +151,10 @@ int blk_rq_map_user(struct request_queue *q, struct request *rq,
 	 */
 	if (len & queue_dma_alignment(q)) {
 		unsigned int pad_len = (queue_dma_alignment(q) & ~len) + 1;
-		struct bio *bio = rq->biotail;
+		struct bio *tail = rq->biotail;
 
-		bio->bi_io_vec[bio->bi_vcnt - 1].bv_len += pad_len;
-		bio->bi_size += pad_len;
+		tail->bi_io_vec[tail->bi_vcnt - 1].bv_len += pad_len;
+		tail->bi_size += pad_len;
 		rq->data_len += pad_len;
 	}
 
-- 
1.5.4.2.200.g99e75


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 5/6] block: remove extern on function definition
       [not found] <5ce117613299590dd08d11d24d3a33d9077fe2b0.1203898924.git.harvey.harrison@gmail.com>
                   ` (2 preceding siblings ...)
  2008-02-25  0:25 ` [PATCH 4/6] smack: make functions static Harvey Harrison
@ 2008-02-25  0:25 ` Harvey Harrison
  2008-02-25  0:25 ` [PATCH 6/6] block: fix shadowed variable warning in blk-map.c Harvey Harrison
  4 siblings, 0 replies; 5+ messages in thread
From: Harvey Harrison @ 2008-02-25  0:25 UTC (permalink / raw)
  To: Linus Torvalds, Jens Axboe; +Cc: LKML, Andrew Morton

Intoduced between 2.6.25-rc2 and -rc3
block/blk-settings.c:319:12: warning: function 'blk_queue_dma_drain' with external linkage has definition

Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
 block/blk-settings.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/block/blk-settings.c b/block/blk-settings.c
index 9a8ffdd..6200415 100644
--- a/block/blk-settings.c
+++ b/block/blk-settings.c
@@ -316,7 +316,7 @@ EXPORT_SYMBOL(blk_queue_stack_limits);
  * device can support otherwise there won't be room for the drain
  * buffer.
  */
-extern int blk_queue_dma_drain(struct request_queue *q,
+int blk_queue_dma_drain(struct request_queue *q,
 			       dma_drain_needed_fn *dma_drain_needed,
 			       void *buf, unsigned int size)
 {
-- 
1.5.4.2.200.g99e75



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-02-25  0:27 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <5ce117613299590dd08d11d24d3a33d9077fe2b0.1203898924.git.harvey.harrison@gmail.com>
2008-02-25  0:25 ` [PATCH 2/6] xen: make blkif_getgeo static Harvey Harrison
2008-02-25  0:25 ` [PATCH 3/6] agp: fix shadowed variable warning in amd-k7-agp.c Harvey Harrison
2008-02-25  0:25 ` [PATCH 4/6] smack: make functions static Harvey Harrison
2008-02-25  0:25 ` [PATCH 5/6] block: remove extern on function definition Harvey Harrison
2008-02-25  0:25 ` [PATCH 6/6] block: fix shadowed variable warning in blk-map.c Harvey Harrison

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).