LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Steven Whitehouse <swhiteho@redhat.com>
To: Denis Cheng <crquan@gmail.com>
Cc: cluster-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] [GFS2] remove gfs2_dev_iops
Date: Wed, 27 Feb 2008 18:08:33 +0000	[thread overview]
Message-ID: <1204135713.3323.1.camel@localhost.localdomain> (raw)
In-Reply-To: <1204010704-11842-1-git-send-email-crquan@gmail.com>

Hi,

Both patches are now in the -nmw git tree. Sorry for the delay. I've
changed the comment on the second one since that commit ID didn't appear
to match up with the right patch.

Steve.

On Tue, 2008-02-26 at 15:25 +0800, Denis Cheng wrote:
> struct inode_operations gfs2_dev_iops is always the same as gfs2_file_iops,
> since Jan 2006, when GFS2 merged into mainstream kernel.
> 
> So one of them could be removed.
> 
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
>  fs/gfs2/inode.c     |    2 +-
>  fs/gfs2/ops_inode.c |   10 ----------
>  fs/gfs2/ops_inode.h |    1 -
>  3 files changed, 1 insertions(+), 12 deletions(-)
> 
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 37725ad..1069ceb 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -149,7 +149,7 @@ void gfs2_set_iop(struct inode *inode)
>  	} else if (S_ISLNK(mode)) {
>  		inode->i_op = &gfs2_symlink_iops;
>  	} else {
> -		inode->i_op = &gfs2_dev_iops;
> +		inode->i_op = &gfs2_file_iops;
>  	}
>  
>  	unlock_new_inode(inode);
> diff --git a/fs/gfs2/ops_inode.c b/fs/gfs2/ops_inode.c
> index e874129..ab9a073 100644
> --- a/fs/gfs2/ops_inode.c
> +++ b/fs/gfs2/ops_inode.c
> @@ -1148,16 +1148,6 @@ const struct inode_operations gfs2_file_iops = {
>  	.removexattr = gfs2_removexattr,
>  };
>  
> -const struct inode_operations gfs2_dev_iops = {
> -	.permission = gfs2_permission,
> -	.setattr = gfs2_setattr,
> -	.getattr = gfs2_getattr,
> -	.setxattr = gfs2_setxattr,
> -	.getxattr = gfs2_getxattr,
> -	.listxattr = gfs2_listxattr,
> -	.removexattr = gfs2_removexattr,
> -};
> -
>  const struct inode_operations gfs2_dir_iops = {
>  	.create = gfs2_create,
>  	.lookup = gfs2_lookup,
> diff --git a/fs/gfs2/ops_inode.h b/fs/gfs2/ops_inode.h
> index fd8cee2..14b4b79 100644
> --- a/fs/gfs2/ops_inode.h
> +++ b/fs/gfs2/ops_inode.h
> @@ -15,7 +15,6 @@
>  extern const struct inode_operations gfs2_file_iops;
>  extern const struct inode_operations gfs2_dir_iops;
>  extern const struct inode_operations gfs2_symlink_iops;
> -extern const struct inode_operations gfs2_dev_iops;
>  extern const struct file_operations gfs2_file_fops;
>  extern const struct file_operations gfs2_dir_fops;
>  extern const struct file_operations gfs2_file_fops_nolock;


      parent reply	other threads:[~2008-02-27 18:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] < <1204010704-11842-1-git-send-email-crquan@gmail.com>
2008-02-26  7:25 ` Denis Cheng
2008-02-26  7:25   ` [PATCH 2/2] [GFS2] re-support special inode Denis Cheng
2008-02-27 18:08   ` Steven Whitehouse [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204135713.3323.1.camel@localhost.localdomain \
    --to=swhiteho@redhat.com \
    --cc=cluster-devel@redhat.com \
    --cc=crquan@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 1/2] [GFS2] remove gfs2_dev_iops' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).