LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mike Galbraith <efault@gmx.de>
To: zkopex mtrof <zkopex@yahoo.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Regression in 2.6.25-rcX] CD/DVD writer no longer works
Date: Thu, 28 Feb 2008 05:21:56 +0100	[thread overview]
Message-ID: <1204172516.10161.14.camel@homer.simson.net> (raw)
In-Reply-To: <916729.18642.qm@web45209.mail.sp1.yahoo.com>


On Wed, 2008-02-27 at 19:26 -0800, zkopex mtrof wrote:

> [patch snipped]
> 
> Thank you very much! The patch you supplied fixes the regression!

You're welcome.  In the meantime, I found a better way.

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index ba21d97..7a6f784 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -871,7 +871,7 @@ void scsi_io_completion(struct scsi_cmnd *cmd, unsigned int good_bytes)
 			scsi_end_bidi_request(cmd);
 			return;
 		}
-		req->data_len = scsi_get_resid(cmd);
+		req->data_len = req->raw_data_len = scsi_get_resid(cmd);
 	}
 
 	BUG_ON(blk_bidi_rq(req)); /* bidi not support for !blk_pc_request yet */


> To be honest, I was expecting a few replies from the appropriate
> kernel developers. It looks like I have missed something in
> my regression report.

I think some of those are traveling.

	-Mike


  reply	other threads:[~2008-02-28  4:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-24 20:57 zkopex
2008-02-25  3:36 ` Mike Galbraith
2008-02-28  3:26   ` zkopex mtrof
2008-02-28  4:21     ` Mike Galbraith [this message]
2008-02-28 14:41     ` Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204172516.10161.14.camel@homer.simson.net \
    --to=efault@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zkopex@yahoo.com \
    --subject='Re: [Regression in 2.6.25-rcX] CD/DVD writer no longer works' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).