LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: linux-kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jon Masters <jcm@jonmasters.org>, Rusty Russell <rusty@rustcorp.com.au>
Subject: [PATCH 2.6.25] module: allow ndiswrapper to use GPL-only symbols
Date: Thu, 28 Feb 2008 17:11:02 -0500 [thread overview]
Message-ID: <1204236662.3612.6.camel@dv> (raw)
A change after 2.6.24 broke ndiswrapper by accidentally removing its
access to GPL-only symbols. Revert that change and add comments about
the reasons why ndiswrapper and driverloader are treated in a special
way.
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
kernel/module.c | 9 ++++++++-
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/kernel/module.c b/kernel/module.c
index 901cd6a..a11f523 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -1933,8 +1933,15 @@ static struct module *load_module(void __user *umod,
/* Set up license info based on the info section */
set_license(mod, get_modinfo(sechdrs, infoindex, "license"));
+ /*
+ * ndiswrapper is under GPL by itself, but loads proprietary modules.
+ * Don't use add_taint_module(), as it would prevent ndiswrapper from
+ * using GPL-only symbols it needs.
+ */
if (strcmp(mod->name, "ndiswrapper") == 0)
- add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
+ add_taint(TAINT_PROPRIETARY_MODULE);
+
+ /* driverloader was caught wrongly pretending to be under GPL */
if (strcmp(mod->name, "driverloader") == 0)
add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
--
Regards,
Pavel Roskin
next reply other threads:[~2008-02-28 22:11 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-28 22:11 Pavel Roskin [this message]
2008-02-28 23:25 ` Linus Torvalds
2008-02-29 6:20 ` Pavel Roskin
2008-02-29 16:08 ` Linus Torvalds
2008-02-29 16:54 ` Chris Friesen
2008-02-29 17:06 ` Linus Torvalds
2008-02-29 17:59 ` Chris Friesen
2008-03-06 14:56 ` David Woodhouse
2008-02-29 16:59 ` Zan Lynx
2008-02-29 17:07 ` Linus Torvalds
2008-02-29 17:20 ` Pavel Roskin
2008-02-29 17:33 ` Linus Torvalds
2008-02-29 19:39 ` Pavel Roskin
2008-02-29 19:53 ` Linus Torvalds
2008-02-29 20:08 ` Pavel Roskin
2008-02-29 20:28 ` Linus Torvalds
2008-02-29 21:13 ` Pavel Roskin
2008-02-29 20:17 ` John W. Linville
2008-02-29 20:40 ` David Newall
2008-02-29 20:59 ` Pavel Roskin
2008-02-29 21:08 ` David Newall
2008-02-29 22:17 ` Pavel Roskin
2008-03-01 8:15 ` David Newall
2008-02-29 20:44 ` Pavel Roskin
2008-02-29 21:15 ` Ingo Molnar
2008-02-29 22:31 ` Pavel Roskin
2008-03-03 10:57 ` Ingo Molnar
2008-03-04 5:37 ` Pavel Roskin
2008-03-04 12:57 ` Ingo Molnar
2008-03-04 17:19 ` Linus Torvalds
2008-03-04 17:38 ` Greg KH
2008-03-04 17:45 ` Pavel Roskin
2008-03-04 21:20 ` Ingo Molnar
2008-03-04 23:23 ` Pavel Roskin
2008-03-04 20:51 ` Ingo Molnar
2008-03-04 23:25 ` Jiri Kosina
2008-03-05 13:21 ` Ingo Molnar
2008-02-29 17:18 ` Jon Masters
2008-02-29 21:55 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204236662.3612.6.camel@dv \
--to=proski@gnu.org \
--cc=jcm@jonmasters.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--subject='Re: [PATCH 2.6.25] module: allow ndiswrapper to use GPL-only symbols' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).