LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Zhang, Rui" <rui.zhang@intel.com>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
	ming.m.lin@intel.com
Subject: Re: 2.6.25 regression/oops on boot (ACPI related?)
Date: Fri, 29 Feb 2008 07:38:54 +0800	[thread overview]
Message-ID: <1204241934.10256.151.camel@acpi-hp-zz.sh.intel.com> (raw)
In-Reply-To: <20080229075449.GK9009@earth.li>


On Fri, 2008-02-29 at 15:54 +0800, Jonathan McDowell wrote:
> On Fri, Feb 29, 2008 at 01:20:27AM +0800, Zhang, Rui wrote:
> > Please attach the acpidump output using the latest pmtools at :
> > http://www.kernel.org/pub/linux/kernel/people/lenb/acpi/utils/
> > Please attach the result of "cat /proc/acpi/thermal_zone/*/*" as
> well.
> 
> I've attached the output of acpidump. The cat results in this output:
> 
> [noodles@meepok /proc/acpi/thermal_zone/THRM]$ cat *
> 0 - Active; 1 - Passive
> <polling disabled>
> state:                   ok
> temperature:             40 C
> Segmentation fault
> 
> It also causes a general protection fault, which I've attached as
> well.
> 
> This is a stock Debian kernel:
> 
> Linux meepok 2.6.24-1-amd64 #1 SMP Mon Feb 11 13:47:43 UTC 2008 x86_64
> GNU/Linux
> 
> I have a patch from Ming Lin to try out but it'll have to wait until
> tomorrow before I can do so.
> 
We've root caused the problem and Lin Ming's patch should work for you.
Please give it a try. :)

From: Lin Ming <ming.m.lin@intel.com>

Fix a memory overflow bug when copying
NULL internal package element object to external.

Signed-off-by: Lin Ming <ming.m.lin@intel.com>
Signed-off-by: Zhang Rui <rui.zhang@intel.com>
---
 drivers/acpi/utilities/utobject.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/drivers/acpi/utilities/utobject.c
===================================================================
--- linux-2.6.orig/drivers/acpi/utilities/utobject.c
+++ linux-2.6/drivers/acpi/utilities/utobject.c
@@ -432,7 +432,7 @@ acpi_ut_get_simple_object_size(union acp
 	 * element -- which is legal)
 	 */
 	if (!internal_object) {
-		*obj_length = 0;
+		*obj_length = sizeof(union acpi_object);
 		return_ACPI_STATUS(AE_OK);
 	}
 



  reply	other threads:[~2008-02-29  8:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 20:08 Jonathan McDowell
2008-02-28 17:20 ` Zhang, Rui
2008-02-29  7:54   ` Jonathan McDowell
2008-02-28 23:38     ` Zhang, Rui [this message]
2008-03-01 15:27       ` Jonathan McDowell
2008-03-10 14:37         ` Jonathan McDowell
2008-03-10 15:01           ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204241934.10256.151.camel@acpi-hp-zz.sh.intel.com \
    --to=rui.zhang@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.m.lin@intel.com \
    --cc=noodles@earth.li \
    --subject='Re: 2.6.25 regression/oops on boot (ACPI related?)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).