LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Gerhard Pircher <gerhard_pircher@gmx.net>
Cc: linuxppc-dev@ozlabs.org, dri-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, airlied@linux.ie
Subject: Re: [BUG/RFC/PATCH] drm: Fix for non-coherent DMA PowerPC
Date: Mon, 03 Mar 2008 09:54:07 +1100	[thread overview]
Message-ID: <1204498447.15052.485.camel@pasglop> (raw)
In-Reply-To: <20080302223012.90210@gmx.net>


> Okay, I changed the code to this:
> 
> >DRM_DEBUG("dev = 0x%x, bus_address = 0x%x, bus_to_virt = 0x%lx, max_pages = 0x%x\n",
> >	(unsigned int)&dev->pdev->dev, bus_address,
> >	(unsigned long)virt_to_bus(bus_address), max_pages);
> >
> >if (gart_info->gart_table_location == DRM_ATI_GART_MAIN) {
> >	DRM_DEBUG("calling dma_sync_single_for_device()\n");
> >	dma_sync_single_for_device(&dev->pdev->dev,
> >		bus_address,
> >		max_pages * sizeof(u32),
> >		PCI_DMA_TODEVICE);
> >}
> 
> It looks like dma_sync_single_for_device() is not called here (the debug
> messages don't show up in kernel log). I also included the Xorg.0.log
> file.

Ok, try adding more debug then, around the calls to pci_map_single() in
that same function and dump the arguments. I'm especially interested
in the result of the various page_address().

Ben.



  reply	other threads:[~2008-03-02 22:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-25 23:41 [RFC/PATCH] " Benjamin Herrenschmidt
2008-03-02 11:05 ` [BUG/RFC/PATCH] " Gerhard Pircher
2008-03-02 20:47   ` Benjamin Herrenschmidt
2008-03-02 22:30     ` Gerhard Pircher
2008-03-02 22:54       ` Benjamin Herrenschmidt [this message]
2008-03-02 22:56       ` Benjamin Herrenschmidt
2008-03-03 19:51         ` Gerhard Pircher
2008-03-03 20:44           ` Benjamin Herrenschmidt
2008-03-03 21:37             ` Gerhard Pircher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204498447.15052.485.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=gerhard_pircher@gmx.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --subject='Re: [BUG/RFC/PATCH] drm: Fix for non-coherent DMA PowerPC' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).