LKML Archive on
help / color / mirror / Atom feed
From: Peter Zijlstra <>
To: Jesper Juhl <>
Cc: LKML <>,
	Linus Torvalds <>,, Ingo Molnar <>
Subject: Re: [PATCH] leak less memory in failure paths of alloc_rt_sched_group()
Date: Mon, 03 Mar 2008 00:19:52 +0100	[thread overview]
Message-ID: <1204499992.6240.109.camel@lappy> (raw)
In-Reply-To: <>

On Mon, 2008-03-03 at 00:09 +0100, Jesper Juhl wrote:
> In kernel/sched.c b/kernel/sched.c::alloc_rt_sched_group() we currently do 
> some paired memory allocations, and if one fails we bail out without 
> freeing the previous one.
> If we fail inside the loop we should proably roll the whole thing back. 
> This patch does not do that, it simply frees the first member of the 
> paired alloc if the second fails. This is not perfect, but it's a simple 
> change that will, at least, result in us leaking a little less than we 
> currently do when an allocation fails.
> So, not perfect, but better than what we currently have.
> Please consider applying.

Doesn't the following handle that:

	if (!alloc_rt_sched_group())
		goto err;



 	free all relevant stuff

  reply	other threads:[~2008-03-02 23:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-02 23:09 Jesper Juhl
2008-03-02 23:19 ` Peter Zijlstra [this message]
2008-03-02 23:29   ` Jesper Juhl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204499992.6240.109.camel@lappy \ \ \ \ \ \ \
    --subject='Re: [PATCH] leak less memory in failure paths of alloc_rt_sched_group()' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).