LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: oakad@exemail.com.au
To: linux-kernel@vger.kernel.org
Cc: akpm@linux-foundation.org, Alex Dubov <oakad@yahoo.com>
Subject: [PATCH 10/11] memstick: try harder to recover from unsuccessful interface mode switch
Date: Wed,  5 Mar 2008 03:02:27 +1100	[thread overview]
Message-ID: <1204646548-27466-11-git-send-email-oakad@exemail.com.au> (raw)
In-Reply-To: <1204646548-27466-10-git-send-email-oakad@exemail.com.au>

From: Alex Dubov <oakad@yahoo.com>

Signed-off-by: Alex Dubov <oakad@yahoo.com>
---
 drivers/memstick/core/mspro_block.c |   21 +++++++++++++++++++--
 1 files changed, 19 insertions(+), 2 deletions(-)

diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_block.c
index 62b913b..1d637e4 100644
--- a/drivers/memstick/core/mspro_block.c
+++ b/drivers/memstick/core/mspro_block.c
@@ -16,6 +16,7 @@
 #include <linux/idr.h>
 #include <linux/hdreg.h>
 #include <linux/kthread.h>
+#include <linux/delay.h>
 #include <linux/memstick.h>
 
 #define DRIVER_NAME "mspro_block"
@@ -820,7 +821,7 @@ static int mspro_block_switch_to_parallel(struct memstick_dev *card)
 	struct memstick_host *host = card->host;
 	struct mspro_block_data *msb = memstick_get_drvdata(card);
 	struct mspro_param_register param = {
-		.system = 0,
+		.system = MEMSTICK_SYS_PAR4,
 		.data_count = 0,
 		.data_address = 0,
 		.tpc_param = 0
@@ -845,8 +846,24 @@ static int mspro_block_switch_to_parallel(struct memstick_dev *card)
 	wait_for_completion(&card->mrq_complete);
 
 	if (card->current_mrq.error) {
-		msb->system = 0x80;
+		msb->system = MEMSTICK_SYS_SERIAL;
+		host->set_param(host, MEMSTICK_POWER, MEMSTICK_POWER_OFF);
+		msleep(1000);
+		host->set_param(host, MEMSTICK_POWER, MEMSTICK_POWER_ON);
 		host->set_param(host, MEMSTICK_INTERFACE, MEMSTICK_SERIAL);
+
+		if (memstick_set_rw_addr(card))
+			return card->current_mrq.error;
+
+		param.system = msb->system;
+
+		card->next_request = h_mspro_block_req_init;
+		msb->mrq_handler = h_mspro_block_default;
+		memstick_init_req(&card->current_mrq, MS_TPC_WRITE_REG, &param,
+				  sizeof(param));
+		memstick_new_req(host);
+		wait_for_completion(&card->mrq_complete);
+
 		return -EFAULT;
 	}
 
-- 
1.5.3.6


  reply	other threads:[~2008-03-04 16:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 16:02 MemoryStick driver updates oakad
2008-03-04 16:02 ` [PATCH 01/11] memstick: introduce correct definitions in the header oakad
2008-03-04 16:02   ` [PATCH 02/11] memstick: add memstick_suspend/resume_host methods oakad
2008-03-04 16:02     ` [PATCH 03/11] memstick: make sure number of command retries is exactly as specified oakad
2008-03-04 16:02       ` [PATCH 04/11] memstick: drop DRIVER_VERSION numbers as meaningless oakad
2008-03-04 16:02         ` [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code oakad
2008-03-04 16:02           ` [PATCH 06/11] tifm: fix memorystick host initialization code oakad
2008-03-04 16:02             ` [PATCH 07/11] tifm: clear interrupt mask bits before setting them on adapter init oakad
2008-03-04 16:02               ` [PATCH 08/11] memstick: add support for decoding "specfile" media attributes oakad
2008-03-04 16:02                 ` [PATCH 09/11] memstick: fix parsing of "assembly_date" attribute field oakad
2008-03-04 16:02                   ` oakad [this message]
2008-03-04 16:02                     ` [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller oakad
2008-03-05 23:17                       ` Andrew Morton
2008-03-05 22:59           ` [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code Andrew Morton
2008-03-05 23:21 ` MemoryStick driver updates Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204646548-27466-11-git-send-email-oakad@exemail.com.au \
    --to=oakad@exemail.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oakad@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).