LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@suse.de>
To: linux-kernel@vger.kernel.org
Cc: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@suse.de>
Subject: [PATCH 5/8] PM: fix new mutex-locking bug in the PM core
Date: Tue, 4 Mar 2008 15:18:49 -0800 [thread overview]
Message-ID: <1204672732-3127-5-git-send-email-gregkh@suse.de> (raw)
In-Reply-To: <20080304231519.GC3073@suse.de>
From: Alan Stern <stern@rowland.harvard.edu>
This patch (as1041) fixes a bug introduced by the
acquire-all-device-semaphores reversion. The error pathway of
dpm_suspend() fails to reacquire a mutex it should be holding.
Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/base/power/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/base/power/main.c b/drivers/base/power/main.c
index b0c16f6..d887d5c 100644
--- a/drivers/base/power/main.c
+++ b/drivers/base/power/main.c
@@ -428,6 +428,7 @@ static int dpm_suspend(pm_message_t state)
mutex_unlock(&dpm_list_mtx);
error = suspend_device(dev, state);
+ mutex_lock(&dpm_list_mtx);
if (error) {
printk(KERN_ERR "Could not suspend device %s: "
"error %d%s\n",
@@ -438,7 +439,6 @@ static int dpm_suspend(pm_message_t state)
""));
break;
}
- mutex_lock(&dpm_list_mtx);
if (!list_empty(&dev->power.entry))
list_move(&dev->power.entry, &dpm_off);
}
--
1.5.4.3
next prev parent reply other threads:[~2008-03-04 23:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 23:15 [GIT PATCH] driver core fixes against 2.6.25-rc3 git Greg KH
2008-03-04 23:18 ` [PATCH 1/8] driver core: fix up Kconfig text for CONFIG_SYSFS_DEPRECATED Greg Kroah-Hartman
2008-03-05 15:58 ` Valdis.Kletnieks
2008-03-05 16:05 ` Greg KH
2008-03-05 21:24 ` Valdis.Kletnieks
2008-03-04 23:18 ` [PATCH 2/8] sysfs: CONFIG_SYSFS_DEPRECATED fix Greg Kroah-Hartman
2008-03-04 23:18 ` [PATCH 3/8] kobject: properly initialize ksets Greg Kroah-Hartman
2008-03-04 23:18 ` [PATCH 4/8] PM: Do not acquire device semaphores upfront during suspend Greg Kroah-Hartman
2008-03-04 23:18 ` Greg Kroah-Hartman [this message]
2008-03-04 23:18 ` [PATCH 6/8] driver core: Remove dpm_sysfs_remove() from error path of device_add() Greg Kroah-Hartman
2008-03-04 23:18 ` [PATCH 7/8] Driver core: Fix cleanup when failing device_add() Greg Kroah-Hartman
2008-03-04 23:18 ` [PATCH 8/8] debugfs: fix sparse warnings Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1204672732-3127-5-git-send-email-gregkh@suse.de \
--to=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--subject='Re: [PATCH 5/8] PM: fix new mutex-locking bug in the PM core' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).