LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia@diku.dk>
Cc: e1000-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	xfs-masters <xfs-masters@oss.sgi.com>
Subject: Re: [PATCH] drivers/net: convert & to &&
Date: Thu, 06 Mar 2008 09:59:07 -0800	[thread overview]
Message-ID: <1204826347.5541.20.camel@localhost> (raw)
In-Reply-To: <Pine.LNX.4.58.0803061841000.1669@pc-041.diku.dk>

On Thu, 2008-03-06 at 18:41 +0100, Julia Lawall wrote:
> diff -u -p a/drivers/net/e1000/e1000_main.c b/drivers/net/e1000/e1000_main.c
> --- a/drivers/net/e1000/e1000_main.c	2008-02-20 22:09:26.000000000 +0100
> +++ b/drivers/net/e1000/e1000_main.c	2008-03-06 17:30:20.000000000 +0100
> @@ -3872,10 +3872,12 @@ e1000_intr_msi(int irq, void *data)
>  	adapter->total_tx_packets = 0;
>  	adapter->total_rx_packets = 0;
> 
> -	for (i = 0; i < E1000_MAX_INTR; i++)
> -		if (unlikely(!adapter->clean_rx(adapter, adapter->rx_ring) &
> -		   !e1000_clean_tx_irq(adapter, adapter->tx_ring)))
> +	for (i = 0; i < E1000_MAX_INTR; i++) {
> +		boolean_t c1 = adapter->clean_rx(adapter, adapter->rx_ring);
> +		boolean_t c2 = e1000_clean_tx_irq(adapter, adapter->tx_ring);
> +		if (unlikely(!c1 && !c2))
>  			break;
> +	}

Perhaps also a s/boolean_t/bool/g kernel wide?

$ grep -wrl boolean_t *

drivers/net/e1000/e1000.h
drivers/net/e1000/e1000_ethtool.c
drivers/net/e1000/e1000_hw.c
drivers/net/e1000/e1000_hw.h
drivers/net/e1000/e1000_main.c
drivers/net/e1000/e1000_osdep.h
drivers/net/ixgb/ixgb.h
drivers/net/ixgb/ixgb_ee.c
drivers/net/ixgb/ixgb_ee.h
drivers/net/ixgb/ixgb_ethtool.c
drivers/net/ixgb/ixgb_hw.c
drivers/net/ixgb/ixgb_hw.h
drivers/net/ixgb/ixgb_main.c
drivers/net/ixgb/ixgb_osdep.h
fs/xfs/quota/xfs_dquot.c
fs/xfs/quota/xfs_qm.c
fs/xfs/quota/xfs_qm.h
fs/xfs/quota/xfs_qm_syscalls.c
fs/xfs/quota/xfs_trans_dquot.c
fs/xfs/xfs_ialloc.c
fs/xfs/xfs_ialloc.h
fs/xfs/xfs_inode.c
fs/xfs/xfs_inode.h
fs/xfs/xfs_log.c
fs/xfs/xfs_vfsops.c
fs/xfs/xfs_utils.c
fs/xfs/xfs_types.h
fs/xfs/xfs_vnodeops.c



  reply	other threads:[~2008-03-06 18:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-06 17:41 Julia Lawall
2008-03-06 17:59 ` Joe Perches [this message]
2008-03-06 18:07   ` [E1000-devel] " Kok, Auke
2008-03-07  1:22     ` [PATCH] drivers/net/e1000 - Convert boolean_t to bool Joe Perches
2008-03-07  1:24     ` [PATCH] drivers/net/ixgb - convert " Joe Perches
2008-03-07 17:14       ` Kok, Auke
2008-03-07 18:20     ` [E1000-devel] [PATCH] drivers/net: convert & to && Joe Perches
2008-03-07 18:38       ` Kok, Auke
2008-03-10 12:20       ` walter harms

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204826347.5541.20.camel@localhost \
    --to=joe@perches.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xfs-masters@oss.sgi.com \
    --subject='Re: [PATCH] drivers/net: convert & to &&' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).