LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: Tejun Heo <htejun@gmail.com>, Mark Lord <liml@rtr.ca>,
	Matthew Wilcox <matthew@wil.cx>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: ata_ram driver
Date: Thu, 06 Mar 2008 20:44:30 -0600	[thread overview]
Message-ID: <1204857870.3062.121.camel@localhost.localdomain> (raw)
In-Reply-To: <47D0A58D.3050500@garzik.org>

On Thu, 2008-03-06 at 21:16 -0500, Jeff Garzik wrote:
> Tejun Heo wrote:
> > James Bottomley wrote:
> >>> Yeap, sure.  It's the combination of things that always made me put this
> >>> off.  Is there a function I can call to just shutdown the host instead
> >>> of destroying it?
> >> Not really ... the process of unbinding the ULDs causes their remove
> >> methods to call shudown.  It is possible to separate this in the ULDS;
> >> but the original design was to make remove and shutdown be similar for
> >> the very reason that if you're removing the driver with unflushed data
> >> in the cache, we'd really like it flushed (flush is called from
> >> shutdown) because you have no way to talk to the device after this
> >> without reinserting the driver.
> > 
> > The problem is that libata EH and other stuff aren't ready to let go of
> > the SCSI host up until the last moment and that last moment can't be
> > moved before SCSI host destruction because shutdown sequence (flush and
> > spindown) requires live EH.  I think this can be solved by shooting down
> > individual sdev's instead of destroying the scsi_host.
> 
> I'm curious how the picture would change, if we used a scsi_host for 
> each ata_host.

It would probably make the whole paradigm a lot easier.  Currently, if
you look at the transport classes that do this type of thing, they
shadow host and add port and other components as extra bits.  libata
does a rather strange thing trying to have one SCSI host per SATA port,
so scsi_host and ata_host don't match up.  Then on destruction you can
just follow the standard SCSI teardown path.

James



      reply	other threads:[~2008-03-07  2:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22 20:09 Matthew Wilcox
2008-02-22 21:27 ` Mark Lord
2008-03-06  8:21   ` Tejun Heo
2008-03-06 15:28     ` James Bottomley
2008-03-06 23:55       ` Tejun Heo
2008-03-07  0:01         ` James Bottomley
2008-03-07  0:13           ` Tejun Heo
2008-03-07  0:22             ` James Bottomley
2008-03-07  0:28               ` Tejun Heo
2008-03-07  0:39                 ` James Bottomley
2008-03-07  0:43                   ` Tejun Heo
2008-03-07  3:08                     ` [PATCH 1/2] scsi: export scsi_forget_host() Tejun Heo
2008-03-07  3:11                       ` [PATCH 2/2] libata: kill SCSI devices before detaching ata_host Tejun Heo
2008-03-07  2:16                 ` ata_ram driver Jeff Garzik
2008-03-07  2:44                   ` James Bottomley [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1204857870.3062.121.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --subject='Re: ata_ram driver' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).