LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Duane Griffin" <duaneg@dghda.com>
To: linux-ext4@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Theodore Tso <tytso@mit.edu>,
	sct@redhat.com, akpm@linux-foundation.org, adilger@clusterfs.com,
	Duane Griffin <duaneg@dghda.com>
Subject: jbd/2: eliminate code duplication and gracefully handle cache initialisation failure
Date: Sat,  8 Mar 2008 18:37:33 +0000	[thread overview]
Message-ID: <1205001459-5291-1-git-send-email-duaneg@dghda.com> (raw)

 fs/jbd/journal.c  |  149 +++++++++++++++++++++++-------------------------
 fs/jbd/revoke.c   |  164 +++++++++++++++++++++++------------------------------
 fs/jbd2/journal.c |  154 ++++++++++++++++++++++++-------------------------
 fs/jbd2/revoke.c  |  164 +++++++++++++++++++++++------------------------------
 4 files changed, 291 insertions(+), 340 deletions(-)

This is version 2 of the jdb/2 patches to eliminate code duplication and
gracefully handle cace initialisation failure.

Changes since V1:
 * Check whether caches are initialised in journal_init_common. If not then
   attempt to initialise them once before failing.
 * Addressed all Andreas Dilger's comments.
 * Modified the initialisation/destruction methods to match Christoph Hellwig's
   suggestions.
 * Rolled the if/assertion and debugfs changes into the main patch.

Andrew, please drop the earlier versions of these patches and replace them with
these ones, thanks.

Cheers,
Duane.

-- 
"I never could learn to drink that blood and call it wine" - Bob Dylan

             reply	other threads:[~2008-03-08 18:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-08 18:37 Duane Griffin [this message]
2008-03-08 18:37 ` [PATCH] jbd: eliminate duplicated code in revocation table init/destroy functions Duane Griffin
2008-03-08 18:37   ` [PATCH] jbd2: " Duane Griffin
2008-03-08 18:37     ` [PATCH] jbd: tidy up revoke cache initialisation and destruction Duane Griffin
2008-03-08 18:37       ` [PATCH] jbd2: " Duane Griffin
2008-03-08 18:37         ` [PATCH] jbd: handle cache initialisation failure gracefully when statically compiled in Duane Griffin
2008-03-08 18:37           ` [PATCH] jbd2: " Duane Griffin
2008-03-10 19:46 ` jbd/2: eliminate code duplication and gracefully handle cache initialisation failure Andrew Morton
2008-03-12  2:46   ` Duane Griffin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1205001459-5291-1-git-send-email-duaneg@dghda.com \
    --to=duaneg@dghda.com \
    --cc=adilger@clusterfs.com \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    --cc=tytso@mit.edu \
    --subject='Re: jbd/2: eliminate code duplication and gracefully handle cache initialisation failure' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).