LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] drivers: fix dma_get_required_mask
@ 2008-03-09 16:57 James Bottomley
  0 siblings, 0 replies; only message in thread
From: James Bottomley @ 2008-03-09 16:57 UTC (permalink / raw)
  To: Greg KH; +Cc: linux-kernel, linux-scsi, Michael Tokarev

There's a bug in the current implementation of dma_get_required_mask()
where it ands the returned mask with the current device mask.  This
rather defeats the purpose if you're using the call to determine what
your mask should be (since you will at that time have the default
DMA_32BIT_MASK).  This bug results in any driver that uses this function
*always* getting a 32 bit mask, which is wrong.

Fix by removing the and with dev->dma_mask.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>

---

This is a pretty nasty bug which can cause mysterious slow downs and
panics on >4GB machines (we've just had one on an aic79xx production
system).

It probably also needs to be backported as far as it will go.

James

diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index efaf282..911ec60 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
@@ -648,7 +648,7 @@ u64 dma_get_required_mask(struct device *dev)
 		high_totalram += high_totalram - 1;
 		mask = (((u64)high_totalram) << 32) + 0xffffffff;
 	}
-	return mask & *dev->dma_mask;
+	return mask;
 }
 EXPORT_SYMBOL_GPL(dma_get_required_mask);
 #endif



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-03-09 16:58 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-09 16:57 [PATCH] drivers: fix dma_get_required_mask James Bottomley

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).