Re: [PATCH][v4] Modify loop device to be able to manage partitions of the disk image

[Laurent Vivier <Laurent.Vivier@bull.net>]

Le mercredi 19 mars 2008 à 14:28 -0700, Andrew Morton a écrit :
> On Wed, 19 Mar 2008 21:24:41 +0100
> Laurent Vivier <Laurent.Vivier@bull.net> wrote:
> 
> > Le mercredi 19 mars 2008 __ 13:11 -0700, Randy Dunlap a __crit :
> > > On Wed, 19 Mar 2008 13:36:07 +0100 Laurent Vivier wrote:
> > > 
> > > > This patch allows to use loop device with partitionned disk image.
> > > > 
> > > > Original behavior of loop is not modified.
> > > > 
> > > > A new parameter is introduced to define how many partition we want to be
> > > > able to manage per loop device. This parameter is "max_part".
> > > 
> > > What happened to the update to Documentation/kernel-parameters.txt
> > > that was in v3?
> > 
> > Well, perhaps I didn't understand the comment of Andrew:
> > 
> > "This shouldn't be needed."
> > 
> > I though it means I should remove it. So, Andrew ???
> 
> No, given that all module_param() options are available via the boot
> command line when the module is linked into vmlinux, we don't document them
> separately.

"No" is "To document max_part is not needed"

or

"No" is "you must not remove parameter documentation from your patch" ?

> There should be a way of auto-generating all the documentation for all the
> module parameters from their MODULE_PARM_DESC's.  And there probably is,
> but I'm not sure how this is done (?)
> 
> (does `make help', fails to spot it).
> 
> You can do `modinfo loop' but that probably doesn't work if
> CONFIG_BLK_DEV_LOOP=y?
> 
> 
> 
> I assume you tested the "loop.max_part=N" option?

Yes, I did (with N=63)

Regards,
Laurent
-- 
------------- Laurent.Vivier@bull.net ---------------
"The best way to predict the future is to invent it."
- Alan Kay