LKML Archive on
help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <>
To: Alan Cox <>
Cc: Guennadi Liakhovetski <>,
	Jeff Garzik <>, Tim Ellis <>,
Subject: Re: [PATCH] Work around breakage introduced in pata_sil680 by switching it to MMIO
Date: Wed, 26 Mar 2008 19:20:22 +1100	[thread overview]
Message-ID: <1206519623.10573.39.camel@pasglop> (raw)
In-Reply-To: <20080325233629.1fcc2eaa@core>

On Tue, 2008-03-25 at 23:36 +0000, Alan Cox wrote:
> On Wed, 26 Mar 2008 00:31:19 +0100 (CET)
> Guennadi Liakhovetski <> wrote:
> > pata_sil680 is broken on Linkstation amd Kurobox HG machines since 2.6.24. 
> > Work around the breakage until a real fix is found.
> > 
> > Signed-off-by: Guennadi Liakhovetski <>
> Just disable the mmio patch on all systems - we know it doesn't work, we
> know what work needs to be done, it should remain off for everyone until
> that work is done. It should never have been merged in the first place
> and I think my statement to that effect has been proven nicely.

Agreed. We did some patches to work on the possible write posting
issues, and they didn't fix the problem, though they still should go in
ultimately (after more testing, I need to dig them back out of my pile).

So I think the MMIO is on standby now until we really corner what's
going on. I hope to be able to work a bit on Guennadi's setup one of
these days though I can't promise, I may instead get that SiL controller
out of a cell blade and stick it in every HW I have around see if I can
reproduce the problem. I think I have a couple different revisions even.

We need to keep it enabled for the QS20 cell blades as it's the only way
those will boot (and they happen to apparently not suffer from any
adverse effect, we've tortured them pretty deeply, could be luck due to
how the bridge works on them, or due to other workarounds we do for
horrid breakage in the PCI host bridge that end up making everything
else work too) but everybody else can stick with PIO.

Jeff, can you ask Linus to pull my patch (the one Alan just acked) that
does that in .25 ?


  reply	other threads:[~2008-03-26  8:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-12 15:58 [PATCH] libata: Add MMIO support to pata_sil680 Tim Ellis
2008-02-12 21:02 ` Benjamin Herrenschmidt
2008-02-12 21:42   ` Alan Cox
2008-02-15 15:52   ` Guennadi Liakhovetski
2008-02-15 15:53     ` Alan Cox
2008-02-15 21:45       ` Benjamin Herrenschmidt
2008-02-15 22:27         ` Alan Cox
2008-02-15 22:55           ` Benjamin Herrenschmidt
2008-02-15 23:56         ` Tim Ellis
2008-02-25 22:57           ` Jeff Garzik
2008-02-25 23:06             ` Guennadi Liakhovetski
2008-02-26  0:58             ` Benjamin Herrenschmidt
2008-03-25 23:31               ` [PATCH] Work around breakage introduced in pata_sil680 by switching it to MMIO Guennadi Liakhovetski
2008-03-25 23:36                 ` Alan Cox
2008-03-26  8:20                   ` Benjamin Herrenschmidt [this message]
2008-02-15 21:36     ` [PATCH] libata: Add MMIO support to pata_sil680 Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1206519623.10573.39.camel@pasglop \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).