LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] NULL noise: drivers/misc
@ 2008-03-29 3:07 Al Viro
2008-03-29 18:46 ` Harvey Harrison
0 siblings, 1 reply; 2+ messages in thread
From: Al Viro @ 2008-03-29 3:07 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---
drivers/misc/fujitsu-laptop.c | 2 +-
drivers/misc/ibmasm/module.c | 2 +-
drivers/misc/lkdtm.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/misc/fujitsu-laptop.c b/drivers/misc/fujitsu-laptop.c
index 1cfd7f3..e2e7c05 100644
--- a/drivers/misc/fujitsu-laptop.c
+++ b/drivers/misc/fujitsu-laptop.c
@@ -231,7 +231,7 @@ static int acpi_fujitsu_remove(struct acpi_device *device, int type)
if (!device || !acpi_driver_data(device))
return -EINVAL;
- fujitsu->acpi_handle = 0;
+ fujitsu->acpi_handle = NULL;
return 0;
}
diff --git a/drivers/misc/ibmasm/module.c b/drivers/misc/ibmasm/module.c
index 4f9d4a9..b5f6add 100644
--- a/drivers/misc/ibmasm/module.c
+++ b/drivers/misc/ibmasm/module.c
@@ -106,7 +106,7 @@ static int __devinit ibmasm_init_one(struct pci_dev *pdev, const struct pci_devi
sp->irq = pdev->irq;
sp->base_address = ioremap(pci_resource_start(pdev, 0),
pci_resource_len(pdev, 0));
- if (sp->base_address == 0) {
+ if (!sp->base_address) {
dev_err(sp->dev, "Failed to ioremap pci memory\n");
result = -ENODEV;
goto error_ioremap;
diff --git a/drivers/misc/lkdtm.c b/drivers/misc/lkdtm.c
index c884730..1bfe5d1 100644
--- a/drivers/misc/lkdtm.c
+++ b/drivers/misc/lkdtm.c
@@ -197,7 +197,7 @@ static int lkdtm_parse_commandline(void)
{
int i;
- if (cpoint_name == INVALID || cpoint_type == NONE ||
+ if (cpoint_name == NULL || cpoint_type == NULL ||
cpoint_count < 1 || recur_count < 1)
return -EINVAL;
--
1.5.3.GIT
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] NULL noise: drivers/misc
2008-03-29 3:07 [PATCH] NULL noise: drivers/misc Al Viro
@ 2008-03-29 18:46 ` Harvey Harrison
0 siblings, 0 replies; 2+ messages in thread
From: Harvey Harrison @ 2008-03-29 18:46 UTC (permalink / raw)
To: Al Viro; +Cc: torvalds, linux-kernel
On Sat, 2008-03-29 at 03:07 +0000, Al Viro wrote:
> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
> ---
> drivers/misc/fujitsu-laptop.c | 2 +-
> drivers/misc/ibmasm/module.c | 2 +-
> drivers/misc/lkdtm.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
Not duplicated in -mm, please apply.
Harvey
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-29 18:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-29 3:07 [PATCH] NULL noise: drivers/misc Al Viro
2008-03-29 18:46 ` Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).