LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Nigel Cunningham <ncunningham@crca.org.au>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: pm list <linux-pm@lists.linux-foundation.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>, Greg KH <greg@kroah.com>,
	Len Brown <lenb@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
	Alexey Starikovskiy <astarikovskiy@suse.de>,
	David Brownell <david-b@pacbell.net>, Pavel Machek <pavel@ucw.cz>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Oliver Neukum <oliver@neukum.org>
Subject: Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)
Date: Wed, 02 Apr 2008 09:32:18 +1100	[thread overview]
Message-ID: <1207089138.23143.117.camel@nigel-laptop> (raw)
In-Reply-To: <200804012357.30529.rjw@sisk.pl>

Hi.

On Tue, 2008-04-01 at 23:57 +0200, Rafael J. Wysocki wrote:
> On Tuesday, 1 of April 2008, Nigel Cunningham wrote:
> > Hi Rafael etc.
> > 
> > On Tue, 2008-04-01 at 22:12 +0200, Rafael J. Wysocki wrote:
> > > 'ext' means 'extended'.  The idea is that the 'extended' version will be used
> > > by bus types / driver types that don't need to implement the _noirq callbacks.
> > > Both the platform and PCI bus types generally allow drivers to use _noirq
> > > callbacks, so they use 'struct pm_ext_ops', as well as their corresponding
> > > driver types.
> > 
> > Do you mean to say in the first sentence "...that _do_ need to implement..."?
> 
> Yes, sorry.

Okay. Thanks!

> > If not, then extended sounds like a misnomer and the two 
> > sentences seem to contradict one another.
> > 
> > [...]
> > 
> > > > > + *	However, drivers may NOT assume anything about the availability of the
> > > > > + *	user space at that time and it is not correct to request firmware from
> > > > > + *	within @prepare() (it's too late to do that).
> > > > 
> > > > That doesn't sound good. It would be good to be able to get drivers to
> > > > request firmware early in the process.
> > > 
> > > That will be possible when we drop the freezer.
> > 
> > Yeah, but right now, it seems to me to be a bogus limitation for drivers
> > to have no way of automatically loading firmware when you're about to
> > hibernate. (Of course I've since been reminded of the notifier chain -
> > that should probably be mentioned here as the way of achieving this).
> 
> This is a tricky stuff, though, because the notifier is used for disabling the
> user mode helpers too ...

Hmm. Yet another notifier?
 
> > By the way, I'm going to go on record now as saying I think dropping the
> > freezer is a silly idea. I'm therefore currently considering including
> > the freezer in TuxOnice from the time it gets dropped from mainline. I
> > know that will only make it less likely that TuxOnIce gets merged, but
> > I've given up caring about that anyway - caring about merging is
> > pointless when the people who decide if it gets merged don't care.
> 
> Well, I'm just not sure if dropping the freezer entirely will actually work,
> but we won't know that if we don't try.
> 
> There's been a lot of pressure on going into this direction recently and
> in principle it seems to be doable at least for suspend.  Hibernation is
> another issue, but IMO it's better to focus on suspend first.

For suspend, I agree with dropping its use. For hibernation...

Nigel


  reply	other threads:[~2008-04-01 22:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-29 22:17 [RFC][PATCH 0/3] PM: Rework suspend and hibernation code for devices (rev. 3) Rafael J. Wysocki
2008-03-29 22:20 ` [RFC][PATCH 1/3] PM: Introduce new top level suspend and hibernation callbacks (rev. 5) Rafael J. Wysocki
2008-03-30  2:54   ` Rafael J. Wysocki
2008-03-31 21:29     ` [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6) Rafael J. Wysocki
2008-04-01  8:15       ` Nigel Cunningham
2008-04-01  8:27         ` Benjamin Herrenschmidt
2008-04-01 14:31           ` Alan Stern
2008-04-01 19:34             ` Nigel Cunningham
2008-04-01 20:16           ` Rafael J. Wysocki
2008-04-01 20:12         ` Rafael J. Wysocki
2008-04-01 20:56           ` Alan Stern
2008-04-01 21:38             ` Nigel Cunningham
2008-04-01 21:59               ` Rafael J. Wysocki
2008-04-01 21:50             ` Rafael J. Wysocki
2008-04-02 14:11               ` Alan Stern
2008-04-02 14:22                 ` Oliver Neukum
2008-04-02 15:13                   ` Alan Stern
2008-04-02 15:28                     ` Oliver Neukum
2008-04-02 16:42                       ` Alan Stern
2008-04-02 20:11                         ` Oliver Neukum
2008-04-02 20:28                           ` Alan Stern
2008-04-01 21:35           ` Nigel Cunningham
2008-04-01 21:57             ` Rafael J. Wysocki
2008-04-01 22:32               ` Nigel Cunningham [this message]
2008-04-01 23:00                 ` Rafael J. Wysocki
2008-04-01  8:37       ` Pavel Machek
2008-04-01 20:23         ` Rafael J. Wysocki
2008-03-29 22:22 ` [RFC][PATCH 2/3] PM: New suspend and hibernation callbacks for platform bus type (rev. 3) Rafael J. Wysocki
2008-03-30  2:56   ` Rafael J. Wysocki
2008-03-29 22:23 ` [RFC][PATCH 3/3] PM: New suspend and hibernation callbacks for PCI " Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1207089138.23143.117.camel@nigel-laptop \
    --to=ncunningham@crca.org.au \
    --cc=astarikovskiy@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=david-b@pacbell.net \
    --cc=greg@kroah.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=oliver@neukum.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    --cc=stern@rowland.harvard.edu \
    --subject='Re: [RFC][PATCH] PM: Introduce new top level suspend and hibernation callbacks (rev. 6)' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).