LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Andrei Popa <andrei.popa@i-neo.ro>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, gregkh@suse.de
Subject: Re: [PATCH] cdc-acm: don't unlock acm->mutex on error path
Date: Wed, 23 Jul 2008 16:36:05 +0300	[thread overview]
Message-ID: <1216820165.4415.35.camel@ierdnac> (raw)
In-Reply-To: <20080723132310.GB4894@martell.zuzino.mipt.ru>


It's ok now, thanks.

On Wed, 2008-07-23 at 17:23 +0400, Alexey Dobriyan wrote:
> On Wed, Jul 23, 2008 at 03:52:36PM +0300, Andrei Popa wrote:
> > I installed gnokii-0.6.22-r2 and gave the command "gnokii --identify"
> > and the kernel oopsed:
> > 
> > BUG: unable to handle kernel NULL pointer dereference at 00000458
> > IP: [<c0444b52>] mutex_unlock+0x0/0xb
> >  [<c03830ae>] acm_tty_open+0x4c/0x214
> 
> Try this:
> 
> [PATCH] cdc-acm: don't unlock acm->mutex on error path
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> ---
> 
>  drivers/usb/class/cdc-acm.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/usb/class/cdc-acm.c
> +++ b/drivers/usb/class/cdc-acm.c
> @@ -595,8 +595,8 @@ static int acm_tty_open(struct tty_struct *tty, struct file *filp)
>  	tasklet_schedule(&acm->urb_task);
>  
>  done:
> -err_out:
>  	mutex_unlock(&acm->mutex);
> +err_out:
>  	mutex_unlock(&open_mutex);
>  	return rv;
>  
> 


  reply	other threads:[~2008-07-23 13:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-23 12:52 kernel oops Andrei Popa
2008-07-23 13:23 ` [PATCH] cdc-acm: don't unlock acm->mutex on error path Alexey Dobriyan
2008-07-23 13:36   ` Andrei Popa [this message]
2008-07-23 17:11 ` kernel oops Vegard Nossum
2008-08-18 16:33   ` Vegard Nossum
2008-08-18 16:39     ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1216820165.4415.35.camel@ierdnac \
    --to=andrei.popa@i-neo.ro \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH] cdc-acm: don'\''t unlock acm->mutex on error path' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).