LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Liam Girdwood <lrg@kernel.org>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <sameo@openedhand.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] regulator: Add WM8400 regulator support
Date: Wed, 10 Sep 2008 20:58:00 +0100	[thread overview]
Message-ID: <1221076680.17091.259.camel@odin> (raw)
In-Reply-To: <20080910194048.GB26985@rakim.wolfsonmicro.main>

On Wed, 2008-09-10 at 20:40 +0100, Mark Brown wrote:
> On Wed, Sep 10, 2008 at 07:39:28PM +0100, Liam Girdwood wrote:
> 
> > > +static unsigned int wm8400_dcdc_get_optimum_mode(struct regulator_dev *dev,
> > > +						 int input_uV, int output_uV,
> > > +						 int load_uA)
> > > +{
> > > +	return REGULATOR_MODE_IDLE;
> > > +}
> > > +
> 
> > This should return NORMAL by default. Probably best to add a lookup
> > table for IDLE & STANDBY if supported.
> 
> Yeah, I've changed it to NORMAL for now.  I'll add the lookup table in a
> followup patch later along with things like support for configuring the
> suspend modes of the device if that's OK?

OK by me.

Thanks

Liam


  reply	other threads:[~2008-09-10 19:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10 18:28 [PATCH 0/2] WM8400 support Mark Brown
2008-09-10 18:28 ` [PATCH 1/2] mfd: Core support for the WM8400 AudioPlus HiFi CODEC and PMU Mark Brown
2008-09-10 18:28   ` [PATCH 2/2] regulator: Add WM8400 regulator support Mark Brown
2008-09-10 18:39     ` Liam Girdwood
2008-09-10 19:40       ` Mark Brown
2008-09-10 19:58         ` Liam Girdwood [this message]
2008-09-10 18:47   ` [PATCH 1/2] mfd: Core support for the WM8400 AudioPlus HiFi CODEC and PMU Liam Girdwood
2008-09-10 19:13     ` Mark Brown
2008-09-10 19:38       ` Liam Girdwood
2008-09-11 10:02         ` Mark Brown
2008-09-12 10:54   ` Samuel Ortiz
2008-09-12 12:05     ` Mark Brown
2008-09-12 10:58 ` [PATCH 0/2] WM8400 support Samuel Ortiz
2008-09-16  9:42 [PATCH 0/2] WM8400 support v2 Mark Brown
2008-09-16  9:43 ` [PATCH 1/2] mfd: Core support for the WM8400 AudioPlus HiFi CODEC and PMU Mark Brown
2008-09-16  9:43   ` [PATCH 2/2] regulator: Add WM8400 regulator support Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1221076680.17091.259.camel@odin \
    --to=lrg@kernel.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sameo@openedhand.com \
    --subject='Re: [PATCH 2/2] regulator: Add WM8400 regulator support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).