LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] add sysctl from printk_tag
@ 2008-09-18  8:05 Yinghai Lu
  2008-09-18 10:06 ` Ingo Molnar
  0 siblings, 1 reply; 3+ messages in thread
From: Yinghai Lu @ 2008-09-18  8:05 UTC (permalink / raw)
  To: Ingo Molnar, Thomas Gleixner, H. Peter Anvin, Andrew Morton
  Cc: linux-kernel, Yinghai Lu

under /proc/sys/kernel/printk_tag/ will have acpi, apic, dev, pci

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>

---
 init/main.c |   56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

Index: linux-2.6/init/main.c
===================================================================
--- linux-2.6.orig/init/main.c
+++ linux-2.6/init/main.c
@@ -63,6 +63,8 @@
 #include <linux/idr.h>
 #include <linux/kmemcheck.h>
 #include <linux/ftrace.h>
+#include <linux/sysctl.h>
+#include <linux/proc_fs.h>
 
 #include <asm/io.h>
 #include <asm/bugs.h>
@@ -395,6 +397,60 @@ static int __init quiet_kernel(char *str
 early_param("debug", debug_kernel);
 early_param("quiet", quiet_kernel);
 
+#ifdef CONFIG_SYSCTL
+static struct ctl_table printk_tag_ctl_dir[] = {
+        {
+                .procname       = "printk_tag",
+                .mode           = 0555,
+        },
+        {0, },
+};
+
+static struct ctl_table printk_tag_ctl_root[] = {
+        {
+                .ctl_name       = CTL_KERN,
+                .procname       = "kernel",
+                .mode           = 0555,
+                .child          = printk_tag_ctl_dir,
+        },
+        {0, },
+};
+
+static int __init proc_printk_tag_init(void)
+{
+        int i;
+        struct ctl_table *entry;
+        char buf[32];
+
+        entry = kcalloc(tag_level_nr + 1, sizeof(struct ctl_table), GFP_KERNEL);
+        if (entry == NULL)
+                return -1;
+
+        WARN_ON(printk_tag_ctl_dir[0].child);
+        printk_tag_ctl_dir[0].child = entry;
+
+
+	for (i = 0; i < tag_level_nr; i++) {
+		int len;
+
+		len = strlen(tag_level[i].name);
+		memset(buf, 0, sizeof(buf));
+		strncpy(buf, tag_level[i].name, len - 1);
+                entry->procname = kstrdup(buf, GFP_KERNEL);
+		entry->data = &tag_level[i].level;
+		entry->maxlen = sizeof(tag_level[i].level);
+                entry->mode = 0644;
+		entry->proc_handler = proc_dointvec;
+                entry++;
+        }
+
+	register_sysctl_table(printk_tag_ctl_root);
+
+	return 0;
+}
+fs_initcall(proc_printk_tag_init);
+#endif
+
 /*
  * Unknown boot options get handed to init, unless they look like
  * failed parameters

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] add sysctl from printk_tag
  2008-09-18  8:05 [PATCH] add sysctl from printk_tag Yinghai Lu
@ 2008-09-18 10:06 ` Ingo Molnar
  2008-09-20 23:05   ` Bjorn Helgaas
  0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2008-09-18 10:06 UTC (permalink / raw)
  To: Yinghai Lu; +Cc: Thomas Gleixner, H. Peter Anvin, Andrew Morton, linux-kernel


* Yinghai Lu <yhlu.kernel@gmail.com> wrote:

> under /proc/sys/kernel/printk_tag/ will have acpi, apic, dev, pci

nice!

> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
> 
> ---
>  init/main.c |   56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 56 insertions(+)
> 
> Index: linux-2.6/init/main.c
> ===================================================================
> --- linux-2.6.orig/init/main.c
> +++ linux-2.6/init/main.c
> @@ -63,6 +63,8 @@
>  #include <linux/idr.h>
>  #include <linux/kmemcheck.h>
>  #include <linux/ftrace.h>
> +#include <linux/sysctl.h>
> +#include <linux/proc_fs.h>
>  
>  #include <asm/io.h>
>  #include <asm/bugs.h>
> @@ -395,6 +397,60 @@ static int __init quiet_kernel(char *str
>  early_param("debug", debug_kernel);
>  early_param("quiet", quiet_kernel);
>  
> +#ifdef CONFIG_SYSCTL
> +static struct ctl_table printk_tag_ctl_dir[] = {
> +        {
> +                .procname       = "printk_tag",
> +                .mode           = 0555,
> +        },
> +        {0, },
> +};
> +
> +static struct ctl_table printk_tag_ctl_root[] = {
> +        {
> +                .ctl_name       = CTL_KERN,
> +                .procname       = "kernel",
> +                .mode           = 0555,
> +                .child          = printk_tag_ctl_dir,
> +        },
> +        {0, },
> +};
> +
> +static int __init proc_printk_tag_init(void)
> +{
> +        int i;
> +        struct ctl_table *entry;
> +        char buf[32];

magic constant.

> +		strncpy(buf, tag_level[i].name, len - 1);
> +                entry->procname = kstrdup(buf, GFP_KERNEL);
> +		entry->data = &tag_level[i].level;
> +		entry->maxlen = sizeof(tag_level[i].level);
> +                entry->mode = 0644;
> +		entry->proc_handler = proc_dointvec;
> +                entry++;
> +        }

hm, whitespace damage in every second line.

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] add sysctl from printk_tag
  2008-09-18 10:06 ` Ingo Molnar
@ 2008-09-20 23:05   ` Bjorn Helgaas
  0 siblings, 0 replies; 3+ messages in thread
From: Bjorn Helgaas @ 2008-09-20 23:05 UTC (permalink / raw)
  To: Ingo Molnar
  Cc: Yinghai Lu, Thomas Gleixner, H. Peter Anvin, Andrew Morton, linux-kernel

On Thursday 18 September 2008 04:06:22 am Ingo Molnar wrote:
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> 
> > under /proc/sys/kernel/printk_tag/ will have acpi, apic, dev, pci
> 
> nice!

Maybe, but it needs an intelligible commit log.  I can read the words,
but they don't make sense.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-09-20 23:05 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-18  8:05 [PATCH] add sysctl from printk_tag Yinghai Lu
2008-09-18 10:06 ` Ingo Molnar
2008-09-20 23:05   ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).