LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Frank Mayhar <fmayhar@google.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Roland McGrath <roland@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 2.6.27-rc5 re-resubmit] Fix itimer/many thread hang.
Date: Tue, 23 Sep 2008 15:56:00 -0700	[thread overview]
Message-ID: <1222210560.3429.20.camel@bobble.smo.corp.google.com> (raw)
In-Reply-To: <20080923135917.GA285@tv-sign.ru>

On Tue, 2008-09-23 at 17:59 +0400, Oleg Nesterov wrote:
> Looks like task_delta_exec() forgets to unlock rq.

Actually it shouldn't be locking rq.  I failed to delete the lock.

> Confused. Unless I misread the patch, tgtimes->totals can be NULL
> on UP too?

Yeah.  I totally messed up on this, too many things going on at once.
I've eliminated the SMP/UP split in sched_stats.h and pulled it all into
the three basic functions.

> (of course, this can't explain the crash)

I'll be investigating this in the morning (I'm at home today and without
a test box).
-- 
Frank Mayhar <fmayhar@google.com>
Google, Inc.


  parent reply	other threads:[~2008-09-23 22:56 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-12 16:54 [PATCH 2.6.27-rc5 resubmit] " Frank Mayhar
2008-09-12 20:27 ` Andrew Morton
2008-09-14 15:06 ` Ingo Molnar
2008-09-14 15:07   ` [PATCH] timers: fix itimer/many thread hang, fix Ingo Molnar
2008-09-14 15:09   ` [PATCH 2.6.27-rc5 resubmit] Fix itimer/many thread hang Ingo Molnar
2008-09-15 18:09     ` Frank Mayhar
2008-09-16  8:41       ` Ingo Molnar
2008-09-17 19:03         ` Frank Mayhar
2008-09-17 19:13           ` Roland McGrath
2008-09-17 20:12             ` Frank Mayhar
2008-09-18 10:23           ` Ingo Molnar
2008-09-18 13:50             ` Frank Mayhar
2008-09-22 20:22             ` [PATCH 2.6.27-rc5 re-resubmit] " Frank Mayhar
2008-09-23 11:40               ` Ingo Molnar
2008-09-23 12:52                 ` [boot crash] " Ingo Molnar
2008-09-23 13:59                 ` Oleg Nesterov
2008-09-23 16:09                   ` Frank Mayhar
2008-09-23 22:56                   ` Frank Mayhar [this message]
2008-09-24 21:23               ` [PATCH 2.6.27-rc5 incremental " Frank Mayhar
2008-09-27 18:08                 ` Ingo Molnar
2008-09-30  6:33                 ` Ingo Molnar
2008-09-30 16:36                   ` Frank Mayhar
2008-10-01 16:20                     ` Frank Mayhar
2008-10-02  9:43                       ` Ingo Molnar
2008-09-14 15:12   ` [PATCH 2.6.27-rc5 resubmit] " Ingo Molnar
2008-09-14 15:14 ` Ingo Molnar
2008-09-14 19:31   ` Roland McGrath
2008-09-15  6:41     ` Ingo Molnar
2008-09-15 17:59       ` Frank Mayhar
2008-09-16  8:39         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222210560.3429.20.camel@bobble.smo.corp.google.com \
    --to=fmayhar@google.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=roland@redhat.com \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH 2.6.27-rc5 re-resubmit] Fix itimer/many thread hang.' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).