LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] sony-laptop: Ignore missing _DIS method on pic device
@ 2008-10-16 21:29 Adam Jackson
2008-10-16 22:49 ` Mattia Dongili
0 siblings, 1 reply; 4+ messages in thread
From: Adam Jackson @ 2008-10-16 21:29 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-acpi, Matthew Garrett, Adam Jackson
From: Matthew Garrett <mjg59@srcf.ucam.org>
At least the Vaio VGN-Z540N doesn't have this method, so let's not fail
to suspend just because it doesn't exist.
Signed-off-by: Adam Jackson <ajax@redhat.com>
---
drivers/misc/sony-laptop.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
index 60775be..b35eb92 100644
--- a/drivers/misc/sony-laptop.c
+++ b/drivers/misc/sony-laptop.c
@@ -2315,8 +2315,10 @@ end:
*/
static int sony_pic_disable(struct acpi_device *device)
{
- if (ACPI_FAILURE(acpi_evaluate_object(device->handle,
- "_DIS", NULL, NULL)))
+ acpi_status ret = acpi_evaluate_object(device->handle, "_DIS", NULL,
+ NULL);
+
+ if (ACPI_FAILURE(ret) && ret != AE_NOT_FOUND)
return -ENXIO;
dprintk("Device disabled\n");
--
1.6.0.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sony-laptop: Ignore missing _DIS method on pic device
2008-10-16 21:29 [PATCH] sony-laptop: Ignore missing _DIS method on pic device Adam Jackson
@ 2008-10-16 22:49 ` Mattia Dongili
2008-10-17 1:03 ` Adam Jackson
2008-10-28 4:59 ` Len Brown
0 siblings, 2 replies; 4+ messages in thread
From: Mattia Dongili @ 2008-10-16 22:49 UTC (permalink / raw)
To: Adam Jackson; +Cc: linux-kernel, linux-acpi, Matthew Garrett
On Thu, Oct 16, 2008 at 05:29:10PM -0400, Adam Jackson wrote:
> From: Matthew Garrett <mjg59@srcf.ucam.org>
>
> At least the Vaio VGN-Z540N doesn't have this method, so let's not fail
> to suspend just because it doesn't exist.
Do you happen to have a DSDT dump for this model? I'd be glad to see it.
> Signed-off-by: Adam Jackson <ajax@redhat.com>
Acked-by: Mattia Dongili <malattia@linux.it>
> ---
> drivers/misc/sony-laptop.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/sony-laptop.c b/drivers/misc/sony-laptop.c
> index 60775be..b35eb92 100644
> --- a/drivers/misc/sony-laptop.c
> +++ b/drivers/misc/sony-laptop.c
> @@ -2315,8 +2315,10 @@ end:
> */
> static int sony_pic_disable(struct acpi_device *device)
> {
> - if (ACPI_FAILURE(acpi_evaluate_object(device->handle,
> - "_DIS", NULL, NULL)))
> + acpi_status ret = acpi_evaluate_object(device->handle, "_DIS", NULL,
> + NULL);
> +
> + if (ACPI_FAILURE(ret) && ret != AE_NOT_FOUND)
> return -ENXIO;
>
> dprintk("Device disabled\n");
> --
> 1.6.0.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
mattia
:wq!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sony-laptop: Ignore missing _DIS method on pic device
2008-10-16 22:49 ` Mattia Dongili
@ 2008-10-17 1:03 ` Adam Jackson
2008-10-28 4:59 ` Len Brown
1 sibling, 0 replies; 4+ messages in thread
From: Adam Jackson @ 2008-10-17 1:03 UTC (permalink / raw)
To: Mattia Dongili; +Cc: linux-kernel, linux-acpi, Matthew Garrett
On Fri, 2008-10-17 at 07:49 +0900, Mattia Dongili wrote:
> On Thu, Oct 16, 2008 at 05:29:10PM -0400, Adam Jackson wrote:
> > From: Matthew Garrett <mjg59@srcf.ucam.org>
> >
> > At least the Vaio VGN-Z540N doesn't have this method, so let's not fail
> > to suspend just because it doesn't exist.
>
> Do you happen to have a DSDT dump for this model? I'd be glad to see it.
'iasl -d' output:
http://people.freedesktop.org/~ajax/synephrine-dsdt.dsl
- ajax
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] sony-laptop: Ignore missing _DIS method on pic device
2008-10-16 22:49 ` Mattia Dongili
2008-10-17 1:03 ` Adam Jackson
@ 2008-10-28 4:59 ` Len Brown
1 sibling, 0 replies; 4+ messages in thread
From: Len Brown @ 2008-10-28 4:59 UTC (permalink / raw)
To: Mattia Dongili; +Cc: Adam Jackson, linux-kernel, linux-acpi, Matthew Garrett
> > At least the Vaio VGN-Z540N doesn't have this method, so let's not fail
> > to suspend just because it doesn't exist.
> > Signed-off-by: Adam Jackson <ajax@redhat.com>
> Acked-by: Mattia Dongili <malattia@linux.it>
applied to acpi-test
thanks,
-len
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-10-28 4:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-16 21:29 [PATCH] sony-laptop: Ignore missing _DIS method on pic device Adam Jackson
2008-10-16 22:49 ` Mattia Dongili
2008-10-17 1:03 ` Adam Jackson
2008-10-28 4:59 ` Len Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).