LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Ingo Molnar <mingo@elte.hu>, Linus Torvalds <torvalds@osdl.org>,
	linux-kernel@vger.kernel.org, David Miller <davem@davemloft.net>,
	linux-pci@vger.kernel.org, yhlu.kernel@gmail.com,
	Andrew Morton <akpm@linux-foundation.org>,
	Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] x86, ioremap: use %pR in printk
Date: Tue, 21 Oct 2008 08:35:18 +1100	[thread overview]
Message-ID: <1224538518.7654.164.camel@pasglop> (raw)
In-Reply-To: <1224507486.27899.31.camel@johannes.berg>

On Mon, 2008-10-20 at 14:58 +0200, Johannes Berg wrote:
> On Mon, 2008-10-20 at 13:36 +0200, Ingo Molnar wrote:
> 
> > +	/* room for the actual number, the "0x" and the final zero */
> > +	char sym[2*sizeof(phys_addr_t) + 2];
> 
> Buffer overflow.

It's actually not going to overflow as we pass the end of the buffer to
"number" but we'll miss a digit.

Ben.



  parent reply	other threads:[~2008-10-20 21:36 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20  4:07 [PATCH 2/2] pci: Use new %pR to print resource ranges Benjamin Herrenschmidt
2008-10-20  7:12 ` [PATCH] x86, ioremap: use %pR in printk Ingo Molnar
2008-10-20  8:34   ` Benjamin Herrenschmidt
2008-10-20  9:05     ` Ingo Molnar
2008-10-20 11:00       ` Ingo Molnar
2008-10-20 11:15         ` Benjamin Herrenschmidt
2008-10-20 11:22           ` Benjamin Herrenschmidt
2008-10-20 11:31             ` Ingo Molnar
2008-10-20 11:36               ` Ingo Molnar
2008-10-20 12:58                 ` Johannes Berg
2008-10-20 13:15                   ` Ingo Molnar
2008-10-20 21:35                   ` Benjamin Herrenschmidt [this message]
2008-10-21  6:47                     ` Johannes Berg
2008-10-20 13:04                 ` Matthew Wilcox
2008-10-20 21:33                 ` Benjamin Herrenschmidt
2008-10-20 21:34                 ` Benjamin Herrenschmidt
2008-10-20 11:30           ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224538518.7654.164.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=jbarnes@virtuousgeek.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@osdl.org \
    --cc=yhlu.kernel@gmail.com \
    --subject='Re: [PATCH] x86, ioremap: use %pR in printk' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).