LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] edac/cell: enable polling mode
@ 2008-10-21 14:07 Jens Osterkamp
  2008-10-21 20:58 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Jens Osterkamp @ 2008-10-21 14:07 UTC (permalink / raw)
  To: Doug Thompson; +Cc: bluesmoke-devel, benh, cbe-oss-dev, arnd, linux-kernel

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>

The edac driver on cell turned out to be not enabled because of a missing op_state.
This patch introduces it. Verified to work on top of Bens next branch.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jens Osterkamp <jens@linux.vnet.ibm.com>

---

Ben, can you please confirm this is the patch you wanted to send upstream ?

Index: linux-2.6/drivers/edac/cell_edac.c
===================================================================
--- linux-2.6.orig/drivers/edac/cell_edac.c
+++ linux-2.6/drivers/edac/cell_edac.c
@@ -9,6 +9,7 @@
  */
 #undef DEBUG
 
+#include <linux/edac.h>
 #include <linux/module.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>
@@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
 	if (regs == NULL)
 		return -ENODEV;
 
+	edac_op_state = EDAC_OPSTATE_POLL;
+
 	/* Get channel population */
 	reg = in_be64(&regs->mic_mnt_cfg);
 	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);
---

Gruß,

Jens

IBM Deutschland Entwicklung GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Erich Baier 
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] edac/cell: enable polling mode
  2008-10-21 14:07 [PATCH] edac/cell: enable polling mode Jens Osterkamp
@ 2008-10-21 20:58 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2008-10-21 20:58 UTC (permalink / raw)
  To: Jens Osterkamp
  Cc: Doug Thompson, bluesmoke-devel, cbe-oss-dev, arnd, linux-kernel

On Tue, 2008-10-21 at 16:07 +0200, Jens Osterkamp wrote:
> From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> 
> The edac driver on cell turned out to be not enabled because of a missing op_state.
> This patch introduces it. Verified to work on top of Bens next branch.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Jens Osterkamp <jens@linux.vnet.ibm.com>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
> 
> Ben, can you please confirm this is the patch you wanted to send upstream ?

Yes.

> Index: linux-2.6/drivers/edac/cell_edac.c
> ===================================================================
> --- linux-2.6.orig/drivers/edac/cell_edac.c
> +++ linux-2.6/drivers/edac/cell_edac.c
> @@ -9,6 +9,7 @@
>   */
>  #undef DEBUG
>  
> +#include <linux/edac.h>
>  #include <linux/module.h>
>  #include <linux/init.h>
>  #include <linux/platform_device.h>
> @@ -164,6 +165,8 @@ static int __devinit cell_edac_probe(str
>  	if (regs == NULL)
>  		return -ENODEV;
>  
> +	edac_op_state = EDAC_OPSTATE_POLL;
> +
>  	/* Get channel population */
>  	reg = in_be64(&regs->mic_mnt_cfg);
>  	dev_dbg(&pdev->dev, "MIC_MNT_CFG = 0x%016lx\n", reg);
> ---
> 
> Gruß,
> 
> Jens
> 
> IBM Deutschland Entwicklung GmbH
> Vorsitzender des Aufsichtsrats: Martin Jetter
> Geschäftsführung: Erich Baier 
> Sitz der Gesellschaft: Böblingen
> Registergericht: Amtsgericht Stuttgart, HRB 243294


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-21 20:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-21 14:07 [PATCH] edac/cell: enable polling mode Jens Osterkamp
2008-10-21 20:58 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).