LKML Archive on
help / color / mirror / Atom feed
From: Carl Love <>
	linux-kernel <>
Subject: [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function
Date: Fri, 24 Oct 2008 11:47:29 -0700	[thread overview]
Message-ID: <1224874049.20229.5.camel@carll-linux-desktop> (raw)

The size of the pm_signal_local array should be equal to the
number of SPUs being configured in the call.  Currently, the
array is of size 4 (NR_PHYS_CTRS) but being indexed by a for 
loop from 0 to 7 (NUM_SPUS_PER_NODE).  

Signed-off-by: Carl Love <>

Index: Cell_kernel_10_24_2008/arch/powerpc/oprofile/op_model_cell.c
--- Cell_kernel_10_24_2008.orig/arch/powerpc/oprofile/op_model_cell.c
+++ Cell_kernel_10_24_2008/arch/powerpc/oprofile/op_model_cell.c
@@ -830,7 +830,7 @@ static int calculate_lfsr(int n)
 static int pm_rtas_activate_spu_profiling(u32 node)
 	int ret, i;
-	struct pm_signal pm_signal_local[NR_PHYS_CTRS];
+	struct pm_signal pm_signal_local[NUM_SPUS_PER_NODE];
 	 * Set up the rtas call to configure the debug bus to

             reply	other threads:[~2008-10-24 18:48 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 18:47 Carl Love [this message]
2008-10-25  4:39 ` Michael Ellerman
2008-10-28 15:17   ` [UDATED PATCH] " Carl Love
2008-10-29  0:51     ` Michael Ellerman
2008-10-29 15:06       ` [UPDATED PATCH VER2] " Carl Love
2008-10-31 15:14         ` Robert Richter
2008-10-27 18:26 ` [Cbe-oss-dev] [PATCH] " Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224874049.20229.5.camel@carll-linux-desktop \ \ \ \ \ \ \
    --subject='Re: [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).