LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function
@ 2008-10-24 18:47 Carl Love
  2008-10-25  4:39 ` Michael Ellerman
  2008-10-27 18:26 ` [Cbe-oss-dev] [PATCH] " Robert Richter
  0 siblings, 2 replies; 7+ messages in thread
From: Carl Love @ 2008-10-24 18:47 UTC (permalink / raw)
  To: oprofile-list, linuxppc-dev, cel, cbe-oss-dev, linux-kernel


The size of the pm_signal_local array should be equal to the
number of SPUs being configured in the call.  Currently, the
array is of size 4 (NR_PHYS_CTRS) but being indexed by a for 
loop from 0 to 7 (NUM_SPUS_PER_NODE).  

Signed-off-by: Carl Love <carll@us.ibm.com>


Index: Cell_kernel_10_24_2008/arch/powerpc/oprofile/op_model_cell.c
===================================================================
--- Cell_kernel_10_24_2008.orig/arch/powerpc/oprofile/op_model_cell.c
+++ Cell_kernel_10_24_2008/arch/powerpc/oprofile/op_model_cell.c
@@ -830,7 +830,7 @@ static int calculate_lfsr(int n)
 static int pm_rtas_activate_spu_profiling(u32 node)
 {
 	int ret, i;
-	struct pm_signal pm_signal_local[NR_PHYS_CTRS];
+	struct pm_signal pm_signal_local[NUM_SPUS_PER_NODE];
 
 	/*
 	 * Set up the rtas call to configure the debug bus to



^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2008-10-31 15:15 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-10-24 18:47 [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in activate spu profiling function Carl Love
2008-10-25  4:39 ` Michael Ellerman
2008-10-28 15:17   ` [UDATED PATCH] " Carl Love
2008-10-29  0:51     ` Michael Ellerman
2008-10-29 15:06       ` [UPDATED PATCH VER2] " Carl Love
2008-10-31 15:14         ` Robert Richter
2008-10-27 18:26 ` [Cbe-oss-dev] [PATCH] " Robert Richter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).