LKML Archive on
help / color / mirror / Atom feed
From: Michael Ellerman <>
To: Carl Love <>
	linux-kernel <>
Subject: Re: [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in	activate spu profiling function
Date: Sat, 25 Oct 2008 15:39:55 +1100	[thread overview]
Message-ID: <1224909595.16090.5.camel@localhost> (raw)
In-Reply-To: <1224874049.20229.5.camel@carll-linux-desktop>

[-- Attachment #1: Type: text/plain, Size: 912 bytes --]

On Fri, 2008-10-24 at 11:47 -0700, Carl Love wrote:
> The size of the pm_signal_local array should be equal to the
> number of SPUs being configured in the call.  Currently, the
> array is of size 4 (NR_PHYS_CTRS) but being indexed by a for 
> loop from 0 to 7 (NUM_SPUS_PER_NODE).  

While you're at it you should change to using ARRAY_SIZE() in the for
loop, and use sizeof in the rtas call - that way you'll only have the
size in one place.

I notice pm_rtas_activate_signals() also allocates a pm_signal_local on
the stack and iterates over it. I take it something guarantees that
count in that routine will not exceed NR_PHYS_CTRS ?


Michael Ellerman
OzLabs, IBM Australia Development Lab

phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2008-10-25  4:40 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-24 18:47 Carl Love
2008-10-25  4:39 ` Michael Ellerman [this message]
2008-10-28 15:17   ` [UDATED PATCH] " Carl Love
2008-10-29  0:51     ` Michael Ellerman
2008-10-29 15:06       ` [UPDATED PATCH VER2] " Carl Love
2008-10-31 15:14         ` Robert Richter
2008-10-27 18:26 ` [Cbe-oss-dev] [PATCH] " Robert Richter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1224909595.16090.5.camel@localhost \ \ \ \ \ \ \ \
    --subject='Re: [Cbe-oss-dev] [PATCH] Cell OProfile: Incorrect local array size in	activate spu profiling function' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).