LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Ben Hutchings <bhutchings@solarflare.com>
To: Jonathan McDowell <noodles@earth.li>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: 2.6.28-rc2 / hso driver oops
Date: Wed, 29 Oct 2008 19:40:11 +0000	[thread overview]
Message-ID: <1225309212.3068.44.camel@achroite> (raw)
In-Reply-To: <20081029164006.GH3162@earth.li>

On Wed, 2008-10-29 at 16:40 +0000, Jonathan McDowell wrote:
> Hi.
> 
> Tried out 2.6.28-rc2 today on my EEE 901 and my Option Icon 225 and got
> the following oops:
> 
> hso: drivers/net/usb/hso.c: 1.2 Option Wireless
> usbcore: registered new interface driver hso
> usb 2-2: new full speed USB device using uhci_hcd and address 3
> usb 2-2: configuration #1 chosen from 1 choice
> hso0: Disabled Privacy Extensions
> BUG: unable to handle kernel NULL pointer dereference at 000000d0
> IP: [<c03589b9>] dev_driver_string+0x1/0x2a

Something passed a null device pointer to dev_printk().

[...]
> [<f81b8265>] ? hso_create_net_device+0x305/0x32d [hso]
[...]

I think that hso_create_rfkill() is the culprit here (and has been
inlined into hso_create_net_device()).  It's using hso_dev->dev as the
first argument to dev_err() and it doesn't look like that field is
initialised except by kzalloc.  At a guess, it should be using
&hso_dev->usb->dev.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.


  reply	other threads:[~2008-10-29 19:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29 16:40 Jonathan McDowell
2008-10-29 19:40 ` Ben Hutchings [this message]
2008-10-30 10:27   ` [PATCH] Cleanup hso rfkill error handling [was: 2.6.28-rc2 / hso driver oops] Jonathan McDowell
2008-10-30 14:44     ` [PATCH] Fix logic error in rfkill_check_duplicity Jonathan McDowell
2008-10-30 20:49       ` Henrique de Moraes Holschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225309212.3068.44.camel@achroite \
    --to=bhutchings@solarflare.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=noodles@earth.li \
    --subject='Re: 2.6.28-rc2 / hso driver oops' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).