LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Roland McGrath <roland@redhat.com>,
	Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
	Yinghai Lu <yinghai@kernel.org>
Subject: RE: cpu2000(both float and int) 13% regression with 2.6.28-rc1
Date: Fri, 31 Oct 2008 09:15:43 +0800	[thread overview]
Message-ID: <1225415743.1685.87.camel@ymzhang> (raw)
In-Reply-To: <7E82351C108FA840AB1866AC776AEC46401F518D@orsmsx505.amr.corp.intel.com>


On Thu, 2008-10-30 at 17:32 -0700, Pallipadi, Venkatesh wrote:
> >-----Original Message-----
> >From: linux-kernel-owner@vger.kernel.org
> >[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Suresh Siddha
> >Sent: Tuesday, October 28, 2008 1:27 PM
> >To: Ingo Molnar
> >Cc: Zhang, Yanmin; LKML; H. Peter Anvin; Siddha, Suresh B;
> >Roland McGrath; Hiroshi Shimamoto; Yinghai Lu
> >Subject: Re: cpu2000(both float and int) 13% regression with 2.6.28-rc1
> >
> >On Tue, Oct 28, 2008 at 01:03:27AM -0700, Ingo Molnar wrote:
> >>
> >> * Zhang, Yanmin <yanmin_zhang@linux.intel.com> wrote:
> >>
> >> > Comparing with 2.6.27, cpu2000 (both float and int) has
> >about 13% regression
> >> > with 2.6.28-rc1 on my new-model x86-64 machine.
> >> >
> >> > I bisected down to below patch.
> >> >
> >> > commit 0afe2db21394820d32646a695eccf3fbfe6ab5c7
> >> > Merge: d847059... 43603c8...
> >> > Author: Ingo Molnar <mingo@elte.hu>
> >> > Date:   Sat Oct 11 20:23:20 2008 +0200
> >> >
> >> >     Merge branch 'x86/unify-cpu-detect' into
> >x86-v28-for-linus-phase4-D
> >> >
> >> >     Conflicts:
> >> >         arch/x86/kernel/cpu/common.c
> >> >         arch/x86/kernel/signal_64.c
> >> >         include/asm-x86/cpufeature.h
> >> >
> >> >
> >> > When I tried to revert it against 2.6.28-rc2, there are
> >many conflictions.
> >
> >Ingo, I will work with Yanmin and report our findings. It is
> >interesting to see
> >double digit regression on cpu2000 benchmark. My understanding is that
> >these benchmarks are not sensitive to signal handling. Also lmbench
> >signal handling(lat_sig) has less than 3-4% regression, because of
> >added overhead duing signal setup and restore. Context switch
> >didn't have
> >any noticeable difference, when I measure before.
> >
> 
> We figured out that this is not related to signals. But to this mismerge here
> 
> >  +#define X86_FEATURE_AMDC1E  (3*32+21) /* AMD C1E detected */
> > + #define X86_FEATURE_XTOPOLOGY       (3*32+21) /* cpu topology enum extensions */
> 
> I had earler sent a patch to fix this.
> http://marc.info/?l=linux-kernel&m=122341178202930&w=2
> 
> But, somehow I don’t see this patch either in Linus's git or in tip.
I confirm it does fix the issues. But the patch need to be ported to 2.6.28-rc2.



      parent reply	other threads:[~2008-10-31  1:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-28  6:32 Zhang, Yanmin
2008-10-28  8:03 ` Ingo Molnar
2008-10-28  8:31   ` Zhang, Yanmin
2008-10-28 20:26   ` Suresh Siddha
2008-10-31  0:32     ` Pallipadi, Venkatesh
2008-10-31  1:08       ` H. Peter Anvin
2008-10-31 10:02         ` Ingo Molnar
2008-10-31 15:53           ` H. Peter Anvin
2008-10-31  1:15       ` Zhang, Yanmin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225415743.1685.87.camel@ymzhang \
    --to=yanmin_zhang@linux.intel.com \
    --cc=h-shimamoto@ct.jp.nec.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=roland@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=yinghai@kernel.org \
    --subject='RE: cpu2000(both float and int) 13% regression with 2.6.28-rc1' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).