LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Viktor Rosendahl <Viktor.Rosendahl@nokia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH 1/1] Make sure that any oops is flushed to the mtdoops console
Date: Fri, 31 Oct 2008 15:05:28 +0200	[thread overview]
Message-ID: <1225458328.16867.23.camel@viktor.research.nokia.com> (raw)
In-Reply-To: <20081030131734.c74e614d.akpm@linux-foundation.org>

On Thu, 2008-10-30 at 13:17 -0700, ext Andrew Morton wrote: 
> On Wed, 22 Oct 2008 18:16:28 +0300
> Viktor Rosendahl <viktor.rosendahl@nokia.com> wrote:
<clip> 
> >  void __attribute__((weak)) bust_spinlocks(int yes)
> > @@ -22,6 +23,7 @@ void __attribute__((weak)) bust_spinlocks(int yes)
> >  #ifdef CONFIG_VT
> >  		unblank_screen();
> >  #endif
> > +		console_unblank();
> >  		if (--oops_in_progress == 0)
> >  			wake_up_klogd();
> >  	}
> 
> That looks logical.  From my reading we can now remove that
> unblank_screen(), because the console_unblank() will call
> vt_console_driver.unblank() for us?

For some reason, we did not think about it here when the N810 kernel was
fixed. It looks good to me but if you do it, then there will be a slight
difference in behavior, since console_unblank() will call
vt_console_driver.unblank() only if the console_sem can be acquired,
otherwise it just returns without doing anything.

Maybe console_unblank() should be changed to not care too much about the
console_sem if an oops is in progress? 

best regards,

Viktor



  reply	other threads:[~2008-10-31 13:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 15:16 [PATCH 0/1] " Viktor Rosendahl
2008-10-22 15:16 ` [PATCH 1/1] " Viktor Rosendahl
2008-10-30 20:17   ` Andrew Morton
2008-10-31 13:05     ` Viktor Rosendahl [this message]
2008-11-05  0:00       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225458328.16867.23.camel@viktor.research.nokia.com \
    --to=viktor.rosendahl@nokia.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --subject='Re: [PATCH 1/1] Make sure that any oops is flushed to the mtdoops console' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).