LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: [PATCH] fix compile breakage caused by x86: add ->pre_time_init to x86_quirks
Date: Fri, 31 Oct 2008 12:47:26 -0500	[thread overview]
Message-ID: <1225475246.3264.10.camel@localhost.localdomain> (raw)
In-Reply-To: <20081030222308.GM30303@elte.hu>

On Thu, 2008-10-30 at 23:23 +0100, Ingo Molnar wrote:
> * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> 
> > >From da69eaed98248bf4b29e94d62a4e01a5c3758669 Mon Sep 17 00:00:00 2001
> > From: James Bottomley <James.Bottomley@HansenPartnership.com>
> > Date: Wed, 29 Oct 2008 13:14:29 -0500
> > Subject: [VOYAGER] x86: add voyager pre_time_init_hook
> > 
> > This was introduced by:
> > 
> > Author: Yinghai Lu <yhlu.kernel@gmail.com>
> > Date:   Sat Jul 19 18:02:26 2008 -0700
> > 
> >     x86: add ->pre_time_init to x86_quirks
> > 
> > In theory, voyager could also make use of the x86_quirks hooks but,
> > unfortunately, they're not set up correctly for that to happen yet.
> 
> okay, so how about setting them up that way instead? That way we win 
> twice: it becomes a tiny bit easier to add Voyager support to the 
> generic platform code, and we also fix the build breakage.

Sure, it should be possible ... but reworking the current quirk
infrastructure would definitely be an enhancement, whereas this is a
compile fix for 2.6.28-rc

James



  reply	other threads:[~2008-10-31 22:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30 21:07 [PATCH] fix compile breakage caused by x86: add ->pre_time_init to x86_quirks James Bottomley
2008-10-30 22:23 ` Ingo Molnar
2008-10-31 17:47   ` James Bottomley [this message]
2008-11-03  9:46     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225475246.3264.10.camel@localhost.localdomain \
    --to=james.bottomley@hansenpartnership.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yhlu.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).