LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: Folkert van Heusden <folkert@vanheusden.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [2.6.26] kobject_add_internal failed for 2:0 with -EEXIST / unable to handle kernel NULL pointer dereference in sysfs_create_link
Date: Mon, 03 Nov 2008 12:55:35 +0100	[thread overview]
Message-ID: <1225713335.7803.1616.camel@twins> (raw)
In-Reply-To: <ac3eb2510811030353i72a2a5f6i8869addea1057cfa@mail.gmail.com>

On Mon, 2008-11-03 at 12:53 +0100, Kay Sievers wrote:
> On Fri, Oct 31, 2008 at 10:28, Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> > On Fri, 2008-10-31 at 00:23 +0100, Kay Sievers wrote:
> >
> >> Peter, it looks like bdi does not work for devices which share a single queue.
> >> If I add:
> >>   --- a/mm/backing-dev.c
> >>  +++ b/mm/backing-dev.c
> >>   @@ -184,6 +184,8 @@ int bdi_register(struct backing_dev_info *bdi,
> >> struct device *parent,
> >>                   goto exit;
> >>           }
> >>
> >>   +       printk("XXXXXXX old bdidev is %p\n", bdi->dev);
> >>   +       printk("XXXXXXX new bdidev is %p\n", dev);
> >>           bdi->dev = dev;
> >>           bdi_debug_register(bdi, dev_name(dev));
> >>
> >> I get:
> >>   $ modprobe floppy
> >>   Floppy drive(s): fd0 is 1.44M, fd1 is 1.44M
> >>   FDC 0 is a S82078B
> >>   XXXXXXX old bdidev is 0000000000000000
> >>   XXXXXXX new bdidev is ffff88001f20cd10
> >>   XXXXXXX old bdidev is ffff88001f20cd10
> >>   XXXXXXX new bdidev is ffff88001f20de30
> >>
> >> which very much looks like bdi will not remove any earlier registered
> >> device, only the last one, right?
> >
> > Sharing a bdi is odd to begin with, let me poke at this a little.
> 
> Yeah, it's odd, but I'm not sure if you want to touch floppy.c. :)
> Any objection to this patch, until you possible fix it differently?
>   http://marc.info/?l=linux-kernel&m=122541569310798&w=4

Non at all, touching floppy.c is dangerous, folks might assume you know
something about it ;-)


      reply	other threads:[~2008-11-03 11:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-28 15:11 Folkert van Heusden
2008-10-28 23:07 ` Kay Sievers
2008-10-29  9:40   ` Folkert van Heusden
2008-10-29 10:01     ` Bryan Wu
2008-10-29 12:28       ` Kay Sievers
2008-10-29 12:25     ` Kay Sievers
2008-10-29 13:27       ` Folkert van Heusden
2008-10-29 14:49         ` Kay Sievers
2008-10-29 15:25           ` Folkert van Heusden
2008-10-29 21:51             ` Kay Sievers
2008-10-30 10:55               ` Folkert van Heusden
2008-10-30 23:06                 ` Kay Sievers
2008-10-30 23:23                   ` Kay Sievers
2008-10-31  1:13                     ` Kay Sievers
2008-10-31  9:28                     ` Peter Zijlstra
2008-11-03 11:53                       ` Kay Sievers
2008-11-03 11:55                         ` Peter Zijlstra [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1225713335.7803.1616.camel@twins \
    --to=a.p.zijlstra@chello.nl \
    --cc=folkert@vanheusden.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [2.6.26] kobject_add_internal failed for 2:0 with -EEXIST / unable to handle kernel NULL pointer dereference in sysfs_create_link' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).