LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com> To: Avi Kivity <avi@redhat.com>, Ingo Molnar <mingo@elte.hu> Cc: "Eric W. Biederman" <ebiederm@xmission.com>, Simon Horman <horms@verge.net.au>, Andrew Morton <akpm@osdl.org>, Vivek Goyal <vgoyal@redhat.com>, Haren Myneni <hbabu@us.ibm.com>, Andrey Borzenkov <arvidjaar@mail.ru>, mingo@redhat.com, "Rafael J. Wysocki" <rjw@sisk.pl>, kexec@lists.infradead.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Eduardo Habkost <ehabkost@redhat.com> Subject: [PATCH 04/16] x86 kdump: Make kdump_nmi_callback() a function ptr on crash_nmi_callback() Date: Tue, 4 Nov 2008 12:52:32 -0200 [thread overview] Message-ID: <1225810364-8990-5-git-send-email-ehabkost@redhat.com> (raw) In-Reply-To: <1225810364-8990-1-git-send-email-ehabkost@redhat.com> The reboot code will use a different function on crash_nmi_callback(). Adding a function pointer parameter to nmi_shootdown_cpus() for that. Signed-off-by: Eduardo Habkost <ehabkost@redhat.com> --- arch/x86/kernel/crash.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/x86/kernel/crash.c b/arch/x86/kernel/crash.c index 7f6e2b2..ffbe54b 100644 --- a/arch/x86/kernel/crash.c +++ b/arch/x86/kernel/crash.c @@ -29,10 +29,13 @@ #include <mach_ipi.h> +typedef void (*nmi_shootdown_cb)(int, struct die_args*); + #if defined(CONFIG_SMP) && defined(CONFIG_X86_LOCAL_APIC) /* This keeps a track of which one is crashing cpu. */ static int crashing_cpu; +static nmi_shootdown_cb shootdown_callback; static atomic_t waiting_for_crash_ipi; @@ -74,7 +77,7 @@ static int crash_nmi_callback(struct notifier_block *self, return NOTIFY_STOP; local_irq_disable(); - kdump_nmi_callback(cpu, (struct die_args*)data); + shootdown_callback(cpu, (struct die_args*)data); atomic_dec(&waiting_for_crash_ipi); /* Assume hlt works */ @@ -94,13 +97,15 @@ static struct notifier_block crash_nmi_nb = { .notifier_call = crash_nmi_callback, }; -static void nmi_shootdown_cpus(void) +static void nmi_shootdown_cpus(nmi_shootdown_cb callback) { unsigned long msecs; /* Make a note of crashing cpu. Will be used in NMI callback.*/ crashing_cpu = safe_smp_processor_id(); + shootdown_callback = callback; + atomic_set(&waiting_for_crash_ipi, num_online_cpus() - 1); /* Would it be better to replace the trap vector here? */ if (register_die_notifier(&crash_nmi_nb)) @@ -123,7 +128,7 @@ static void nmi_shootdown_cpus(void) static void kdump_nmi_shootdown_cpus(void) { - nmi_shootdown_cpus(); + nmi_shootdown_cpus(kdump_nmi_callback); disable_local_APIC(); } -- 1.5.5.GIT
next prev parent reply other threads:[~2008-11-04 14:58 UTC|newest] Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-11-04 14:52 [PATCH 00/14] x86: disable virt on kdump and emergency_restart Eduardo Habkost 2008-11-04 14:52 ` [PATCH 01/16] x86 kdump: Extract kdump-specific code from crash_nmi_callback() Eduardo Habkost 2008-11-04 14:52 ` [PATCH 02/16] x86 kdump: Move crashing_cpu assignment to nmi_shootdown_cpus() Eduardo Habkost 2008-11-04 14:52 ` [PATCH 03/16] x86 kdump: Create kdump_nmi_shootdown_cpus() Eduardo Habkost 2008-11-04 14:52 ` Eduardo Habkost [this message] 2008-11-04 14:52 ` [PATCH 05/16] x86 kdump: Make nmi_shootdown_cpus() non-static Eduardo Habkost 2008-11-04 14:52 ` [PATCH 06/16] x86: Move nmi_shootdown_cpus() to reboot.c Eduardo Habkost 2008-11-04 14:52 ` [PATCH 07/16] x86: Make nmi_shootdown_cpus() available on !SMP and !X86_LOCAL_APIC Eduardo Habkost 2008-11-04 18:15 ` Eduardo Habkost 2008-11-04 14:52 ` [PATCH 08/16] x86: Emergency virtualization disable function Eduardo Habkost 2008-11-05 17:33 ` Eric W. Biederman 2008-11-05 17:52 ` Eduardo Habkost 2008-11-06 9:48 ` Avi Kivity 2008-11-06 10:22 ` Eric W. Biederman 2008-11-06 10:30 ` Avi Kivity 2008-11-06 17:45 ` Eduardo Habkost 2008-11-09 11:23 ` Avi Kivity 2008-11-04 14:52 ` [PATCH 09/16] kdump: Hook emergency_virt_disable() on crash shutdown code Eduardo Habkost 2008-11-05 14:41 ` Vivek Goyal 2008-11-05 15:07 ` Eduardo Habkost 2008-11-04 14:52 ` [PATCH 10/16] x86: disable virtualization on all CPUs if needed, on emergency_restart Eduardo Habkost 2008-11-04 14:52 ` [PATCH 11/16] kvm_x86_ops: crash_hardware_disable() operation Eduardo Habkost 2008-11-04 14:52 ` [PATCH 12/16] kvm: svm: set crash_hardware_disable to svm_hardware_disable Eduardo Habkost 2008-11-04 14:52 ` [PATCH 13/16] kvm: vmx: crash_hardware_disable function Eduardo Habkost 2008-11-04 14:52 ` [PATCH 14/16] kvmx: x86: set kvm_x86_ops earlier on kvm_arch_init() Eduardo Habkost 2008-11-04 14:52 ` [PATCH 15/16] kvm: x86: set kdump virt_disable function on initialization Eduardo Habkost 2008-11-05 17:26 ` Eric W. Biederman 2008-11-05 17:50 ` Eduardo Habkost 2008-11-06 9:44 ` Avi Kivity 2008-11-04 14:52 ` [PATCH 16/16] Revert "x86: default to reboot via ACPI" Eduardo Habkost 2008-11-04 16:54 ` [PATCH 00/14] x86: disable virt on kdump and emergency_restart Avi Kivity 2008-11-05 14:44 ` Vivek Goyal 2008-11-05 15:04 ` Eduardo Habkost 2008-11-06 9:52 ` Avi Kivity 2008-11-05 16:33 ` Ingo Molnar 2008-11-06 9:49 ` Avi Kivity 2008-11-06 12:28 ` Eduardo Habkost
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1225810364-8990-5-git-send-email-ehabkost@redhat.com \ --to=ehabkost@redhat.com \ --cc=akpm@osdl.org \ --cc=arvidjaar@mail.ru \ --cc=avi@redhat.com \ --cc=ebiederm@xmission.com \ --cc=hbabu@us.ibm.com \ --cc=horms@verge.net.au \ --cc=kexec@lists.infradead.org \ --cc=kvm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@elte.hu \ --cc=mingo@redhat.com \ --cc=rjw@sisk.pl \ --cc=vgoyal@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).