LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Eric Paris <eparis@redhat.com>
To: "Serge E. Hallyn" <serue@us.ibm.com>
Cc: linux-kernel@vger.kernel.org, linux-audit@redhat.com,
sgrubb@redhat.com, morgan@kernel.org, viro@ZenIV.linux.org.uk
Subject: Re: [PATCH -v2 4/4] AUDIT: emit new record type showing all capset information
Date: Thu, 06 Nov 2008 14:03:38 -0500 [thread overview]
Message-ID: <1225998218.3300.171.camel@localhost.localdomain> (raw)
In-Reply-To: <20081104165540.GA25093@us.ibm.com>
On Tue, 2008-11-04 at 10:55 -0600, Serge E. Hallyn wrote:
> Quoting Eric Paris (eparis@redhat.com):
> > diff --git a/kernel/capability.c b/kernel/capability.c
> > index 33e51e7..3d7fc70 100644
> > --- a/kernel/capability.c
> > +++ b/kernel/capability.c
> > @@ -7,6 +7,7 @@
> > * 30 May 2002: Cleanup, Robert M. Love <rml@tech9.net>
> > */
> >
> > +#include <linux/audit.h>
> > #include <linux/capability.h>
> > #include <linux/mm.h>
> > #include <linux/module.h>
> > @@ -457,6 +458,8 @@ asmlinkage long sys_capset(cap_user_header_t header, const cap_user_data_t data)
> > i++;
> > }
> >
> > + audit_log_capset(pid, &effective, &inheritable, &permitted);
>
> Shouldn't sys_capset() fail if audit_log_capset() returns -ENOMEM?
yes, I think it should, but look for the next e-mail.....
next prev parent reply other threads:[~2008-11-06 19:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 20:17 [PATCH -v2 1/4] CAPABILITIES: add cpu endian vfs caps structure Eric Paris
2008-11-03 20:17 ` [PATCH -v2 2/4] AUDIT: output permitted and inheritable fcaps in PATH records Eric Paris
2008-11-03 20:17 ` [PATCH -v2 3/4] AUDIT: collect info when execve results in caps in pE Eric Paris
2008-11-04 16:35 ` Serge E. Hallyn
2008-11-04 19:07 ` Eric Paris
2008-11-04 19:28 ` Serge E. Hallyn
2008-11-06 19:26 ` Eric Paris
2008-11-06 19:58 ` Serge E. Hallyn
2008-11-03 20:17 ` [PATCH -v2 4/4] AUDIT: emit new record type showing all capset information Eric Paris
2008-11-04 16:55 ` Serge E. Hallyn
2008-11-06 19:03 ` Eric Paris [this message]
2008-11-04 16:45 ` [PATCH -v2 1/4] CAPABILITIES: add cpu endian vfs caps structure Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1225998218.3300.171.camel@localhost.localdomain \
--to=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=serue@us.ibm.com \
--cc=sgrubb@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).