LKML Archive on lore.kernel.org help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com> To: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, akpm@linux-foundation.org, David Daney <ddaney@caviumnetworks.com>, Tomaso Paoletti <tpaoletti@caviumnetworks.com> Subject: [PATCH 23/29] 8250: Don't clobber spinlocks. Date: Thu, 6 Nov 2008 12:57:01 -0800 [thread overview] Message-ID: <1226005025-27804-1-git-send-email-ddaney@caviumnetworks.com> (raw) In-Reply-To: <491358F5.7040002@caviumnetworks.com> In serial8250_isa_init_ports(), the port's lock is initialized. We should not overwrite it. In early_serial_setup(), only copy in the fields we need. Since the early console code only uses a subset of the fields, these are sufficient. Signed-off-by: David Daney <ddaney@caviumnetworks.com> Signed-off-by: Tomaso Paoletti <tpaoletti@caviumnetworks.com> --- drivers/serial/8250.c | 15 +++++++++++++-- 1 files changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/serial/8250.c b/drivers/serial/8250.c index 303272a..8e28750 100644 --- a/drivers/serial/8250.c +++ b/drivers/serial/8250.c @@ -2752,12 +2752,23 @@ static struct uart_driver serial8250_reg = { */ int __init early_serial_setup(struct uart_port *port) { + struct uart_port *p; + if (port->line >= ARRAY_SIZE(serial8250_ports)) return -ENODEV; serial8250_isa_init_ports(); - serial8250_ports[port->line].port = *port; - serial8250_ports[port->line].port.ops = &serial8250_pops; + p = &serial8250_ports[port->line].port; + p->iobase = port->iobase; + p->membase = port->membase; + p->irq = port->irq; + p->uartclk = port->uartclk; + p->fifosize = port->fifosize; + p->regshift = port->regshift; + p->iotype = port->iotype; + p->flags = port->flags; + p->mapbase = port->mapbase; + p->private_data = port->private_data; return 0; } -- 1.5.6.5
next prev parent reply other threads:[~2008-11-06 20:58 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2008-11-06 20:52 [PATCH 00/29] Add Cavium OCTEON processor support (v3) David Daney 2008-11-06 20:57 ` David Daney [this message] 2008-11-06 20:57 ` [PATCH 24/29] 8250: Serial driver changes to support future Cavium OCTEON serial patches David Daney 2008-11-06 20:57 ` [PATCH 25/29] Serial: Allow port type to be specified when calling serial8250_register_port David Daney 2008-11-06 20:57 ` [PATCH 26/29] 8250: Allow port type to specify bugs that are not probed for David Daney 2008-11-06 20:57 ` [PATCH 27/29] Serial: UART driver changes for Cavium OCTEON David Daney
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1226005025-27804-1-git-send-email-ddaney@caviumnetworks.com \ --to=ddaney@caviumnetworks.com \ --cc=akpm@linux-foundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=linux-serial@vger.kernel.org \ --cc=tpaoletti@caviumnetworks.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).