LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	Jaroslav Kysela <perex@perex.cz>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments
Date: Thu,  6 Nov 2008 21:05:21 -0500	[thread overview]
Message-ID: <1226023521-10037-1-git-send-email-vapier@gentoo.org> (raw)

The snd_BUG_ON() macro should always expand its argument even if we're
forcing it to false.  This kills off unused warnings that did not exist
before the snd_assert() -> snd_BUG_ON() conversion.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 include/sound/core.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/sound/core.h b/include/sound/core.h
index 35424a9..87de9fc 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -387,7 +387,7 @@ void snd_verbose_printd(const char *file, int line, const char *format, ...)
 
 #define snd_printd(fmt, args...)	/* nothing */
 #define snd_BUG()			/* nothing */
-#define snd_BUG_ON(cond)	({/*(void)(cond);*/ 0;})  /* always false */
+#define snd_BUG_ON(cond)	((cond) && 0)  /* always false */
 
 #endif /* CONFIG_SND_DEBUG */
 
-- 
1.6.0.3


             reply	other threads:[~2008-11-07  2:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-07  2:05 Mike Frysinger [this message]
2008-11-07  6:22 ` Takashi Iwai
2008-11-07  7:09   ` Mike Frysinger
2008-11-07  7:15     ` [alsa-devel] " Takashi Iwai
2008-11-07  7:29       ` Mike Frysinger
2008-11-07  7:36         ` Takashi Iwai
2008-11-07  7:56           ` Mike Frysinger
2008-11-07  7:38         ` Takashi Iwai
2008-11-07  7:57           ` Mike Frysinger
2008-11-07  8:03             ` Takashi Iwai
2008-11-07  8:05               ` Mike Frysinger
2008-11-07  8:22                 ` Takashi Iwai
2008-11-07  9:30                   ` Mike Frysinger
2008-11-07  9:56                     ` Takashi Iwai
2008-11-07 10:03                       ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1226023521-10037-1-git-send-email-vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --subject='Re: [PATCH] ALSA: have snd_BUG_ON() always refer to arguments' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).