LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
* [PATCH] Change default for STRICT_DEVMEM
@ 2008-11-07 20:18 Matt LaPlante
  2008-11-07 22:00 ` Alan Cox
  2008-11-08 11:42 ` Ingo Molnar
  0 siblings, 2 replies; 5+ messages in thread
From: Matt LaPlante @ 2008-11-07 20:18 UTC (permalink / raw)
  To: linux-kernel; +Cc: trivial, Matt LaPlante

The recommendation for STRICT_DEVMEM is to select Y,
however the option currently defaults to N.  Have the option
default to Y since it is recommended.

---
 arch/x86/Kconfig.debug |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index 2a3dfbd..a03597c 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -7,6 +7,7 @@ source "lib/Kconfig.debug"
 
 config STRICT_DEVMEM
 	bool "Filter access to /dev/mem"
+	default y
 	help
 	  If this option is disabled, you allow userspace (root) access to all
 	  of memory, including kernel and userspace memory. Accidental
-- 
1.5.6.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Change default for STRICT_DEVMEM
  2008-11-07 20:18 [PATCH] Change default for STRICT_DEVMEM Matt LaPlante
@ 2008-11-07 22:00 ` Alan Cox
  2008-11-07 23:05   ` Arjan van de Ven
  2008-11-07 23:20   ` Matt LaPlante
  2008-11-08 11:42 ` Ingo Molnar
  1 sibling, 2 replies; 5+ messages in thread
From: Alan Cox @ 2008-11-07 22:00 UTC (permalink / raw)
  To: Matt LaPlante; +Cc: linux-kernel, trivial, Matt LaPlante

On Fri,  7 Nov 2008 14:18:36 -0600
Matt LaPlante <kernel1@cyberdogtech.com> wrote:

> The recommendation for STRICT_DEVMEM is to select Y,
> however the option currently defaults to N.  Have the option
> default to Y since it is recommended.

The recommendation is extremely dubious as it breaks a lot of back
compatibility.


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Change default for STRICT_DEVMEM
  2008-11-07 22:00 ` Alan Cox
@ 2008-11-07 23:05   ` Arjan van de Ven
  2008-11-07 23:20   ` Matt LaPlante
  1 sibling, 0 replies; 5+ messages in thread
From: Arjan van de Ven @ 2008-11-07 23:05 UTC (permalink / raw)
  To: Alan Cox; +Cc: Matt LaPlante, linux-kernel, trivial

On Fri, 7 Nov 2008 22:00:38 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> On Fri,  7 Nov 2008 14:18:36 -0600
> Matt LaPlante <kernel1@cyberdogtech.com> wrote:
> 
> > The recommendation for STRICT_DEVMEM is to select Y,
> > however the option currently defaults to N.  Have the option
> > default to Y since it is recommended.
> 
> The recommendation is extremely dubious as it breaks a lot of back
> compatibility.
> 

the default recommendatiom is a typo. It used to be an "other way
around" config option, and it got flipped into a "positive" option
rather than a tripple negative, but the help text didn't get fixed
properly.



-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Change default for STRICT_DEVMEM
  2008-11-07 22:00 ` Alan Cox
  2008-11-07 23:05   ` Arjan van de Ven
@ 2008-11-07 23:20   ` Matt LaPlante
  1 sibling, 0 replies; 5+ messages in thread
From: Matt LaPlante @ 2008-11-07 23:20 UTC (permalink / raw)
  To: Alan Cox; +Cc: Matt LaPlante, linux-kernel, trivial

On Fri, 7 Nov 2008 22:00:38 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

> On Fri,  7 Nov 2008 14:18:36 -0600
> Matt LaPlante <kernel1@cyberdogtech.com> wrote:
> 
> > The recommendation for STRICT_DEVMEM is to select Y,
> > however the option currently defaults to N.  Have the option
> > default to Y since it is recommended.
> 
> The recommendation is extremely dubious as it breaks a lot of back
> compatibility.
> 
Revert the default and toggle the recommendation then?

-- 
Matt LaPlante <kernel@cyberdogtech.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] Change default for STRICT_DEVMEM
  2008-11-07 20:18 [PATCH] Change default for STRICT_DEVMEM Matt LaPlante
  2008-11-07 22:00 ` Alan Cox
@ 2008-11-08 11:42 ` Ingo Molnar
  1 sibling, 0 replies; 5+ messages in thread
From: Ingo Molnar @ 2008-11-08 11:42 UTC (permalink / raw)
  To: Matt LaPlante
  Cc: linux-kernel, Thomas Gleixner, H. Peter Anvin, Arjan van de Ven


* Matt LaPlante <kernel1@cyberdogtech.com> wrote:

> The recommendation for STRICT_DEVMEM is to select Y,
> however the option currently defaults to N.  Have the option
> default to Y since it is recommended.
> 
> ---
>  arch/x86/Kconfig.debug |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

no. This is a special case: due to compatibility we default to N, but 
still we recommend people/distros to enable it. Eventually we can 
switch around the default in the future, but not yet.

	Ingo

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2008-11-08 11:42 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-11-07 20:18 [PATCH] Change default for STRICT_DEVMEM Matt LaPlante
2008-11-07 22:00 ` Alan Cox
2008-11-07 23:05   ` Arjan van de Ven
2008-11-07 23:20   ` Matt LaPlante
2008-11-08 11:42 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).