LKML Archive on lore.kernel.org
help / color / mirror / Atom feed
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Scott Wood <scottwood@freescale.com>
Cc: Anton Blanchard <anton@samba.org>,
	Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
	Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: perf: Fix frequency calculation for overflowing counters
Date: Mon, 17 Jan 2011 18:38:01 +0100	[thread overview]
Message-ID: <1295285881.30950.218.camel@laptop> (raw)
In-Reply-To: <20110117113250.48098aaa@udp111988uds.am.freescale.net>

On Mon, 2011-01-17 at 11:32 -0600, Scott Wood wrote:
> > diff --git a/arch/powerpc/kernel/perf_event.c b/arch/powerpc/kernel/perf_event.c
> > index 5674807..ab6f6be 100644
> > --- a/arch/powerpc/kernel/perf_event.c
> > +++ b/arch/powerpc/kernel/perf_event.c
> > @@ -1212,6 +1212,7 @@ static void record_and_restart(struct perf_event *event, unsigned long val,
> >                       if (left <= 0)
> >                               left = period;
> >                       record = 1;
> > +                     event->hw.last_period = event->hw.sample_period;
> >               }
> >               if (left < 0x80000000LL)
> >                       val = 0x80000000LL - left;

> Does perf_event_fsl_emb.c need this as well (it has almost the same
> record_and_restart code)? 

I would think so.

  reply	other threads:[~2011-01-17 17:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-17  5:17 Anton Blanchard
2011-01-17 10:45 ` [tip:perf/urgent] " tip-bot for Anton Blanchard
2011-01-17 17:32 ` [PATCH] " Scott Wood
2011-01-17 17:38   ` Peter Zijlstra [this message]
2011-01-18 10:44     ` [PATCH] powerpc: perf: Fix frequency calculation for overflowing counters (FSL version) Anton Blanchard
2011-01-19 19:19       ` [tip:perf/urgent] powerpc, " tip-bot for Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1295285881.30950.218.camel@laptop \
    --to=a.p.zijlstra@chello.nl \
    --cc=acme@ghostprotocols.net \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=scottwood@freescale.com \
    --subject='Re: [PATCH] powerpc: perf: Fix frequency calculation for overflowing counters' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).